Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for showing link to file in email #1228

Closed
wants to merge 1 commit into from

Conversation

baukezwaan
Copy link
Contributor

When submitted by non-authenticated user (fixes #1225)

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what circumstances is this method called outside of the use of that controller?

@baukezwaan
Copy link
Contributor Author

In what circumstances is this method called outside of the use of that controller?

Probably when viewing a submission in the CMS, like the screenshot over here #1167

@GuySartorelli
Copy link
Member

Hi @baukezwaan
Thank you for submitting this pull request.
While refining the issue this is linked to, we've defined some acceptance criteria for a successful PR to meet in order to be merged. Can you please check your PR against the acceptance criteria and see if it meets them all, and update it if it needs to be updated to meet them?

@emteknetnz
Copy link
Member

Looked like this PR didn't have much activity for a while, so I've gone ahead and created a new implementation here so I close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants