MNT Fix unit test #1321
Merged
MNT Fix unit test #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 23, 2024
| $html = $userFormsOptionSetField->renderWith(UserFormsOptionSetField::class)->getValue(); | ||
| $html = $userFormsOptionSetField->setTemplate(UserFormsOptionSetField::class)->Field()->getValue(); |
There was a problem hiding this comment.
The Options used in the template is actually an extra property that gets added in the Field() method.
Before this silently failed because it ended up looping over the "iterator" provided by ViewableData::getIterator() in an empty DBText.
Doesn't ultimately affect what the test is meant to test, so no need to backport this.
Closed
23 tasks
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some unit tests. Comments will explain why the changes were needed.
Issue