FIX Set correct proptypes for react components

silverstripe · Dec 8, 2022 · 027393f · 027393f
1 parent 2536fde
commit 027393f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/client/src/components/HistoryViewer/HistoryViewer.js b/client/src/components/HistoryViewer/HistoryViewer.js
@@ -390,16 +390,16 @@ class HistoryViewer extends Component {
 HistoryViewer.propTypes = {
   contextKey: PropTypes.string,
   limit: PropTypes.number,
-  ListComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  ListComponent: PropTypes.elementType.isRequired,
   offset: PropTypes.number,
   recordId: PropTypes.number.isRequired,
   currentVersion: PropTypes.oneOfType([PropTypes.bool, versionType]),
   compare: compareType,
   isInGridField: PropTypes.bool,
   isPreviewable: PropTypes.bool,
   isRevertable: PropTypes.bool,
-  VersionDetailComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
-  CompareWarningComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  VersionDetailComponent: PropTypes.elementType.isRequired,
+  CompareWarningComponent: PropTypes.elementType.isRequired,
   versions: PropTypes.shape({
     versions: PropTypes.shape({
       pageInfo: PropTypes.shape({

diff --git a/client/src/components/HistoryViewer/HistoryViewerToolbar.js b/client/src/components/HistoryViewer/HistoryViewerToolbar.js
@@ -75,8 +75,8 @@ HistoryViewerToolbar.propTypes = {
   actions: PropTypes.shape({
     revertToVersion: PropTypes.func.isRequired,
   }),
-  FormActionComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
-  ViewModeComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  FormActionComponent: PropTypes.elementType.isRequired,
+  ViewModeComponent: PropTypes.elementType.isRequired,
   isLatestVersion: PropTypes.bool,
   isPreviewable: PropTypes.bool,
   isRevertable: PropTypes.bool,

diff --git a/client/src/components/HistoryViewer/HistoryViewerVersion.js b/client/src/components/HistoryViewer/HistoryViewerVersion.js
@@ -244,8 +244,8 @@ HistoryViewerVersion.propTypes = {
   onCompareMode: PropTypes.func,
   compare: compareType,
   compareModeAvailable: PropTypes.bool,
-  StateComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
-  FormActionComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  StateComponent: PropTypes.elementType.isRequired,
+  FormActionComponent: PropTypes.elementType.isRequired,
 };
 
 HistoryViewerVersion.defaultProps = {

diff --git a/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js b/client/src/components/HistoryViewer/HistoryViewerVersionDetail.js
@@ -217,11 +217,11 @@ HistoryViewerVersionDetail.propTypes = {
   isLatestVersion: PropTypes.bool,
   isPreviewable: PropTypes.bool,
   isRevertable: PropTypes.bool,
-  ListComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
-  PreviewComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]),
+  ListComponent: PropTypes.elementType.isRequired,
+  PreviewComponent: PropTypes.elementType,
   recordId: PropTypes.number.isRequired,
   schemaUrl: PropTypes.string.isRequired,
-  ToolbarComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  ToolbarComponent: PropTypes.elementType.isRequired,
   version: versionType,
   compare: PropTypes.oneOfType([
     PropTypes.shape({

diff --git a/client/src/components/HistoryViewer/HistoryViewerVersionList.js b/client/src/components/HistoryViewer/HistoryViewerVersionList.js
@@ -126,10 +126,10 @@ class HistoryViewerVersionList extends PureComponent {
 HistoryViewerVersionList.propTypes = {
   extraClass: PropTypes.oneOfType([PropTypes.string, PropTypes.array, PropTypes.object]),
   showHeader: PropTypes.bool,
-  FormAlertComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
-  HeadingComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  FormAlertComponent: PropTypes.elementType.isRequired,
+  HeadingComponent: PropTypes.elementType.isRequired,
   messages: PropTypes.arrayOf(messageType),
-  VersionComponent: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
+  VersionComponent: PropTypes.elementType.isRequired,
   versions: PropTypes.arrayOf(versionType),
   compare: compareType,
   compareModeAvailable: PropTypes.bool,