DRAFT Allows indexing to continue if an index error occurs, and add log. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adunn49
commented
Oct 9, 2024
| @@ -206,6 +206,11 @@ private function buildIndexedDocumentsList(): ArrayList | |||
| $query->where('ShowInSearch = 1'); | |||
| } | |||
|
|
|||
| // where appropriate, make sure we only show database total for this index | |||
There was a problem hiding this comment.
On a project with indexing for subsites, it was noted that the total documents in the database didn't take into account the subsite (and index) to which the document related to.
adunn49
commented
Oct 30, 2024
| @@ -598,6 +598,11 @@ public function testEvents(): void | |||
| $mock->expects($this->exactly(2)) | |||
| ->method('markIndexed'); | |||
|
|
|||
| $dataObject = DataObjectFakeVersioned::create(['Title' => 'Document']); | |||
There was a problem hiding this comment.
This was failing - a document is needed.
adunn49
commented
Oct 30, 2024
|
|
||
| $this->expectExceptionMessage('Testing failure'); |
There was a problem hiding this comment.
Change in behaviour - rather than throw an exception, we now log the error and continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow indexing to continue even when an individual document might fail to index and return an error. In this case, here we want the error to be clearly logged but the index process to continue.