Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silx.app.view.test.test_plotselection : Added test for CustomPlotSelectionWindow #4145

Merged
merged 2 commits into from
Jul 1, 2024
Merged

silx.app.view.test.test_plotselection : Added test for CustomPlotSelectionWindow #4145

merged 2 commits into from
Jul 1, 2024

Conversation

RebeloAlexis
Copy link
Contributor

@RebeloAlexis RebeloAlexis commented Jun 28, 2024 •
edited
Loading

Added some tests for CustomPlotSelectionWindow

  • Testing the Drop function with a valid dataset
  • Testing the Remove function
  • Testing the ClearAll fonction
  • Testing multiple Y additions
  • Testing the drop function with an invalid dataset

t20100
t20100 reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

CI fails because of an issue with QDropEvent creation (see comments)

@RebeloAlexis RebeloAlexis requested a review from t20100 July 1, 2024 13:10
@t20100 t20100 merged commit 29faee7 into silx-kit:main Jul 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeloAlexis @t20100