Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui, silx view: Updated default Qt binding to Pyside6; CI: Updated config #4170

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Sep 3, 2024

Checklist:


This PR proposes to change the Qt binding priority list to use PySide6 as the default binding.
It also uses PySide6 to generate the Windows executable.

This is worth a major version bump for the next release IMO.

TODO:

  • Test Windows application
  • Make sure it is OK to use manylinux_2_28

related to #4135, closes #4168

@t20100 t20100 added this to the Next release milestone Sep 3, 2024
@t20100
Copy link
Member Author

t20100 commented Sep 3, 2024

CI seg fault with PySide (see PR #4169 for a fix)

@t20100 t20100 marked this pull request as draft September 4, 2024 08:02
@t20100 t20100 force-pushed the pyside6-default branch 3 times, most recently from 1fe1474 to 9c6793a Compare September 4, 2024 10:04
@t20100
Copy link
Member Author

t20100 commented Sep 4, 2024

The release workflow is updated to work with PySide6 as the default Qt binding.

Indeed:

  • Qt6 requires extra system packages
  • PySide6.4 (the minimum required version) requires manylinux_2_28, i.e. Debian 10+, Ubuntu 18.10+.

So with this PR, wheels available on pypi will be manylinux_2_28 instead of manylinux_2014.

It also adds --fail-on-warning when building the documentation to avoid generating the documentation when a module cannot be imported.

@t20100 t20100 force-pushed the pyside6-default branch 2 times, most recently from 6bc6bf7 to 15b05bb Compare September 5, 2024 10:22
@t20100 t20100 changed the title silx.gui, silx view: Updated default Qt binding to Pyside6 silx.gui, silx view: Updated default Qt binding to Pyside6; CI: Updated config Sep 5, 2024
@t20100
Copy link
Member Author

t20100 commented Sep 5, 2024

In order to avoid copy/paste between CI and release workflows, this PR adds a setup-system composite action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing preferred Qt binding from pyqt5 to qt6
1 participant