This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Solution for the issue #9 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok for a class annotated with @SecurityClass. If none, an exception will be thrown. If more than one, an exception will be thrown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a solution for the issue #9.
Now it's possible to extend Security class as much as needed. I've changed the invoke method in Security.java, and instead of looking for the only class that extended Security, now it looks for a class annotated with @SecurityClass. If it finds none or more than one, an exception will be thrown.
If you want to add compatibility for previous versions, you could change the behaviour when no @SecurityClass annotation is found and search in that case for any Security child class, as you were doing.