Minor improvement for loongarch #1281
Closed
+19
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On loongarch, for example simde_mm_srai_epi16, GCC will generate a vsrai.h instruction for '>>' operator if the imm8 is a real immediate const value, otherwise it will generate two instructions vsral.h and vreplgr2vr.h. But for clang it always generates two instructions. So don't use intrinsics directly, instead let the compiler itself to generate instructions based on imm8, which will save one instruction for GCC at least. Same for below: simde_mm_srai_epi32 simde_mm_slli_epi[16/32/64] simde_mm_srli_epi[16/32/64] simde_mm256_slli_epi[16/32/64] simde_mm256_srai_epi[16/32] simde_mm256_srli_epi[16/32/64]
mr-c
approved these changes
Feb 14, 2025
|
Thanks. I'm going to manually merge this when the final tests pass, because I need to amend the commit messages to mention that this is loongarch specific in the first line. |
|
Sorry, it's my fault. I can re-push it again to fix this if you don't mind . |
|
@jinboson No worries, I merged 9462b0a 😄 (FYI, you might find it more convenient if you made a branch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.