Fix for Mixed Content Errors #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This code clears mixed content errors during the load of the Simile Timeline API.
Helpful background context
If a developer was running off an https served website and using a modern browser (such as Chromium or Brave), hard coded http URLs were causing CSS related rendering problems and a failure to load the Timeline library. These errors occurred because the browser was automatically blocking mixed content loading. By changing loading statements to protocol agnostic URLs the errors can be avoiding while still allowing Timeline to run over either http and https.
This PR has the minimum changes required to correct the errors and allow Timeline to load and render properly. I will submit an additional PR, with many more code changes, that updates the documentation and addresses other issues in the code with mixed content.
What are the relevant tickets?
https://groups.google.com/g/simile-widgets/c/8MoBsyyY5v4
Includes new or updated dependencies?
NO