bump to libfaketime 0.9.10 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmeuk
force-pushed
the
new-macos
branch
2 times, most recently
from
3bcf397 to
f0d018d
Compare
- update to libfaketime 0.9.10 - the libfaketime submodules points to the upstream - apply a patch on build - run GHA on macos 12, 13 and 14
instead of changing the Makefile C flags in the patch
Merged
simon-weber
reviewed
May 5, 2024
| @@ -208,7 +204,13 @@ def __exit__(self, *exc): | |||
| os.environ['FAKETIME'] = self._prev_spec | |||
| else: | |||
| del os.environ['FAKETIME'] | |||
| end_callback(self) | |||
There was a problem hiding this comment.
huh, looks like this was a bug before, yeah? it should have been one level out?
There was a problem hiding this comment.
Yes I suppose, else that would imply that the end callback is only called if there was not a previous FAKETIME environment var defined, and I am not sure how it makes sense.
There was a problem hiding this comment.
I can do a fix for this in a separate PR if you prefer.
There was a problem hiding this comment.
looks like it's been fixed. I just wanted to double check it.
|
This looks fantastic; thanks! It'll be so much easier to upgrade libfaketime now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following things
FAKETIME_FMTenvironment var instead of patching libfaketimeFAKETIME_NO_CACHEenv var instead of patching libfaketimefixes #63
fixes #64