Issues #29 (Task formation with tags disjunction), #30 (json report live update during test execution) fixes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkNaumenko
force-pushed
the
Task_formation_algorithm_fixed
branch
4 times, most recently
from
1e3f54c to
00652ef
Compare
ViacheslauBushyla
suggested changes
Jun 20, 2018
lib/parallel_cucumber/runtime.js
Outdated
| } | ||
| }); | ||
| if (matchTags) { | ||
| function pushTask() { |
There was a problem hiding this comment.
method pushTask should take a task as an argument
lib/parallel_cucumber/runtime.js
Outdated
| @@ -226,34 +226,40 @@ var Runtime = function (configuration) { | |||
| Object.keys(options.profiles).forEach(function (profileName) { | |||
| var profile = options.profiles[profileName]; | |||
| // Clone the array using slice() | |||
| var tags = profile.tags ? profile.tags.slice() : []; | |||
| var tags = profile.tags && profile.tags[0] ? profile.tags[0].split(',').slice() : []; | |||
There was a problem hiding this comment.
please, add few comments concerning condition
MarkNaumenko
force-pushed
the
Task_formation_algorithm_fixed
branch
from
00652ef to
3bf66d0
Compare
MarkNaumenko
force-pushed
the
Task_formation_algorithm_fixed
branch
from
3bf66d0 to
2a4f59d
Compare
MarkNaumenko
changed the title
MarkNaumenko
changed the title
MarkNaumenko
force-pushed
the
Task_formation_algorithm_fixed
branch
from
91ba486 to
b28b34e
Compare
MarkNaumenko
changed the title
MarkNaumenko
changed the title
MarkNaumenko
changed the title
MarkNaumenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29
Change runtime.js _getTasks function in order to proper formation task when there are more than one tags split by comma
https://github.com/cucumber/cucumber-js/blob/1.x/docs/cli.md#tags (3rd case with OR e.g. "
@foo,@bar")Issue #30
Report file will be overwriting after each feature to give opportunity of watching report before tests run finished.