-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for mermaid diagrams #145
Conversation
7ee5030
to
c0468e0
Compare
Cool thanks, however could I ask that you turn your code into a If the module is small enough and doesn't have a performance impact, then we can add it by default as well. |
+1 |
@LachlanNewman did you ever get around to publishing a mermaid extension for marked? If not, would you mind if I do it based on your code? |
@simonhaenisch sure go ahead I've just reopened the pull request so we can look at implementing this together. Last time I ran into an issue with passing the extension that's actually the reason I was going to try to put this in the library rather than make it an extension |
src/lib/get-html.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonhaenisch could we have this extension built in. because it requires loading the mermaid executable into the browsers to render the diagrams?
any news about this feature? |
This PR is to support rendering mermaid diagrams.
Closes #124.