Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Solid #861

Merged
merged 17 commits into from
Dec 27, 2024
Merged

Add support for Solid #861

merged 17 commits into from
Dec 27, 2024

Conversation

simonihmig
Copy link
Owner

@simonihmig simonihmig commented Dec 20, 2024

Closes #812

To Do:

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: be0d0b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@responsive-image/solid Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@birkskyum
Copy link

@simonihmig , how can I repro that this is breaking? The responsive-image/apps/solid-start appear to be returning the "ResponsiveImage for Solid"

@simonihmig
Copy link
Owner Author

I have disabled ssr here in the app config, with that client-side seems to work, but surprisingly I still get ssr-related errors in the terminal:

Error when evaluating SSR module /src/images/aurora.jpg.css?_plugin=responsive-image%2Flqip%2Finline-css&className=ri-dyn-1&targetPixels=16&inline=true:
|- Error: Input file is missing: /src/images/aurora.jpg

With ssr enabled I then get also Hydration Mismatch in the browser.

Note that this branch has a lot of WIP stuff on my side, so I wouldn't rule out that something is broken there. Though I wouldn't know how the runtime component stuff would break the build in that way, and the custom vite plugin used here has been working successfully in other non-solid projects!

The other PR (#860 ) though has just plain solid starter plus downgraded vinxie/vite deps, so no way really that my stuff could have broken this...

Either way, thanks for looking into this!

@simonihmig simonihmig force-pushed the solid-component branch 11 times, most recently from f7a0eb1 to 98df2aa Compare December 25, 2024 15:16
@simonihmig simonihmig marked this pull request as ready for review December 27, 2024 12:14
@simonihmig simonihmig merged commit 438a18e into main Dec 27, 2024
12 checks passed
@simonihmig simonihmig deleted the solid-component branch December 27, 2024 12:15
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image component for SolidJS
2 participants