-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Solid #861
Conversation
🦋 Changeset detectedLatest commit: be0d0b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@simonihmig , how can I repro that this is breaking? The responsive-image/apps/solid-start appear to be returning the "ResponsiveImage for Solid" |
I have disabled ssr here in the app config, with that client-side seems to work, but surprisingly I still get ssr-related errors in the terminal:
With ssr enabled I then get also Note that this branch has a lot of WIP stuff on my side, so I wouldn't rule out that something is broken there. Though I wouldn't know how the runtime component stuff would break the build in that way, and the custom vite plugin used here has been working successfully in other non-solid projects! The other PR (#860 ) though has just plain solid starter plus downgraded vinxie/vite deps, so no way really that my stuff could have broken this... Either way, thanks for looking into this! |
f7a0eb1
to
98df2aa
Compare
e82dadd
to
aa531bc
Compare
aa531bc
to
be0d0b8
Compare
Closes #812
To Do: