Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing example file + allowing lmax_theory to set ell range #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixing example file + allowing lmax_theory to set ell range #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9e1aeb
fixing example file + allowing lmax_theory to set ell range
sgiardie Sep 4, 2024
156763f
expanding docs
sgiardie Sep 5, 2024
d1dd5a5
Merge branch 'master' into small-fix
xgarrido Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mflike/foreground.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@
If one wants to use this class as standalone, the ``bands`` dictionary is filled when initializing
``BandpowerForeground``.

The default values of the systematic parameters are set in the ``TTTEEE/TEEE/TT/EE/TE/etc.yaml`` files. They have to be named as ``cal/calT/calE/alpha`` + ``_`` + experiment_channel string (e.g. ``LAT_93/dr6_pa4_f150``).
The default values of the systematic parameters are set in the ``TTTEEE/TEEE/TT/EE/TE/etc.yaml`` files.
They have to be named as ``cal/calT/calE/alpha`` + ``_`` + experiment_channel string (e.g. ``LAT_93/dr6_pa4_f150``).
The default values of the foreground parameters are set in the ``fg_TT/TE/EE.yaml`` files.
If you want to set different parameters settings, do that in the ``params`` block of the ``yaml`` file you will use for running (see the `examples/mflike_example.yaml <https://github.com/simonsobs/LAT_MFLike/blob/master/examples/mflike_example.yaml>`_).
If you want to set different parameters settings, do that in the ``params`` block of the ``yaml`` file
you will use for running (see the `examples/mflike_example.yaml <https://github.com/simonsobs/LAT_MFLike/blob/master/examples/mflike_example.yaml>`_).

.. note::
Note that when you set different foregrounds/systematics parameters in the ``params`` block
Expand Down Expand Up @@ -47,6 +49,7 @@
top_hat_band:
nsteps: 1
bandwidth: 0

"""

import os
Expand Down
8 changes: 5 additions & 3 deletions mflike/mflike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@

If left ``null``, no systematic template is applied.

The values of the systematic parameters are set in the ``TTTEEE/TTTE/TT/EE/TE/etc.yaml`` files corresponding to the classes that inherit the ``_MFLike`` one. They have to be named as
The values of the systematic parameters are set in the ``TTTEEE/TTTE/TT/EE/TE/etc.yaml`` files
corresponding to the classes that inherit the ``_MFLike`` one. They have to be named as
``cal/calT/calE/alpha`` + ``_`` + experiment_channel string (e.g. ``LAT_93/dr6_pa4_f150``).
"""

Expand Down Expand Up @@ -105,7 +106,7 @@ def initialize(self):
self.log.info("Initialized!")

def get_fg_requirements(self):
return {"ells": self.l_bpws,
return {"ells": self.l_bpws[:self.lmax_theory + 1],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always a bit scared when cutting numpy array since I never know what the first indice is. Basically if self.l_bpws starts at 2 then I think we have a problem

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, l_bpws should start from 2 if I remember well. So to have it arriving up to lmax_theory we should put [:self.lmax_theory -1]

"requested_cls": self.requested_cls,
"experiments": self.experiments,
"bands": self.bands}
Expand All @@ -119,7 +120,8 @@ def get_requirements(self):
"""

return {"fg_totals": self.get_fg_requirements(),
"Cl": {k: max(c, self.lmax_theory + 1) for k, c in self.lcuts.items()}}
"Cl": {k: self.lmax_theory + 1 for k, _ in self.lcuts.items()}}
#"Cl": {k: max(c, self.lmax_theory + 1) for k, c in self.lcuts.items()}}

def logp(self, **params_values):
cl = self.provider.get_Cl(ell_factor=True)
Expand Down