Merge pull request #120 from simonsobs/dev

Fix type errors
simonsobs · Sep 9, 2024 · f8231c7 · f8231c7
2 parents bb38406 + fa83a45
commit f8231c7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/tests/schema/mutations/test_delete_runs.py b/tests/schema/mutations/test_delete_runs.py
@@ -2,6 +2,7 @@
 from hypothesis import given, note
 from hypothesis import strategies as st
 from sqlalchemy import select
+from strawberry.types import ExecutionResult
 
 from nextline_rdb.db import DB
 from nextline_rdb.models import Run
@@ -60,6 +61,7 @@ async def test_delete_runs(data: st.DataObject) -> None:
         )
         note(f'resp: {resp}')
 
+        assert isinstance(resp, ExecutionResult)
         assert resp.data
 
         expected = {run.id for run in to_delete}

diff --git a/tests/schema/queries/test_pagination.py b/tests/schema/queries/test_pagination.py
@@ -5,6 +5,7 @@
 import strawberry
 from hypothesis import given, note
 from hypothesis import strategies as st
+from strawberry.types import ExecutionResult
 
 from nextline_rdb.db import DB
 from nextline_rdb.models import Run
@@ -56,6 +57,7 @@ async def test_all(runs: list[Run]) -> None:
         note(f'nodes_saved: {nodes_saved}')
 
         resp = await schema.execute(QUERY_RDB_RUNS, context_value={'db': db})
+        assert isinstance(resp, ExecutionResult)
         assert resp.data
 
         all_runs = resp.data['rdb']['runs']
@@ -101,6 +103,7 @@ async def test_forward(runs: list[Run], first: int) -> None:
                 variable_values=dict(variables),
                 context_value={'db': db},
             )
+            assert isinstance(resp, ExecutionResult)
             assert resp.data
 
             all_runs = resp.data['rdb']['runs']
@@ -153,6 +156,7 @@ async def test_backward(runs: list[Run], last: int) -> None:
                 variable_values=dict(variables),
                 context_value={'db': db},
             )
+            assert isinstance(resp, ExecutionResult)
             assert resp.data
 
             all_runs = resp.data['rdb']['runs']
@@ -191,6 +195,7 @@ async def test_cursor(runs: list[Run]) -> None:
         note(f'nodes_saved: {nodes_saved}')
 
         resp = await schema.execute(QUERY_RDB_RUNS, context_value={'db': db})
+        assert isinstance(resp, ExecutionResult)
         assert resp.data
 
         all_runs = resp.data['rdb']['runs']
@@ -237,5 +242,6 @@ async def test_error(variables: Variables) -> None:
             context_value={'db': db},
         )
 
+        assert isinstance(resp, ExecutionResult)
         assert not resp.data
         assert resp.errors
diff --git a/tests/schema/queries/test_rdb.py b/tests/schema/queries/test_rdb.py
@@ -1,5 +1,6 @@
 import strawberry
 from hypothesis import Phase, given, note, settings
+from strawberry.types import ExecutionResult
 
 from nextline_rdb.db import DB
 from nextline_rdb.models import Run
@@ -21,6 +22,7 @@ async def test_history(runs: list[Run]) -> None:
 
         resp = await schema.execute(QUERY_RDB_CONNECTIONS, context_value={'db': db})
 
+    assert isinstance(resp, ExecutionResult)
     assert resp.data
     rdb = resp.data['rdb']
     runs_ = rdb['runs']['edges']

diff --git a/tests/schema/queries/test_run.py b/tests/schema/queries/test_run.py
@@ -1,6 +1,7 @@
 import strawberry
 from hypothesis import Phase, given, note, settings
 from hypothesis import strategies as st
+from strawberry.types import ExecutionResult
 
 from nextline_rdb.db import DB
 from nextline_rdb.models import Run
@@ -66,7 +67,8 @@ async def test_run(data: st.DataObject) -> None:
             QUERY_RDB_RUN, variable_values=variables, context_value={'db': db}
         )
         note(f'resp: {resp}')
-
+
+        assert isinstance(resp, ExecutionResult)
         assert resp.data
 
         run_ = resp.data['rdb']['run']