Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Base to Model and update tests and type hints #8

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Conversation

TaiSakuma
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (35b2648) 92.47% compared to head (eff0d8c) 94.31%.
Report is 101 commits behind head on main.

Files Patch % Lines
tests/alembic/conftest.py 78.94% 4 Missing ⚠️
tests/db.py 94.73% 2 Missing ⚠️
src/nextline_rdb/utils/safe.py 95.45% 1 Missing ⚠️
src/nextline_rdb/utils/strategies/misc.py 96.77% 1 Missing ⚠️
tests/test_write.py 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   92.47%   94.31%   +1.84%     
==========================================
  Files          51       70      +19     
  Lines        1395     1988     +593     
  Branches      243      375     +132     
==========================================
+ Hits         1290     1875     +585     
- Misses         83       91       +8     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaiSakuma TaiSakuma merged commit 3aa7907 into main Nov 15, 2023
@TaiSakuma TaiSakuma deleted the test branch November 15, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant