Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ping_BBB function in wiregrid_encoder #560

Closed
wants to merge 2 commits into from

Conversation

sadachi5
Copy link
Contributor

@sadachi5 sadachi5 commented Nov 7, 2023

Description

Add ping_BBB() command in the wiregrid_encoder agent.
This function checks the connection to the beagleboneblack for the wiregrid.
It returns True or False.

Motivation and Context

This function is useful for the sorunlib script for wiregrid to check the connection to the BBB before the calibration.

How Has This Been Tested?

The new function has not been tested yet.

The doc of wiregrid_encoder was modified.
In socs/requirements.txt, ping3 was added for ping_BBB() function.
--ip-adderss is added in the arguments for the wiregrid_encoder agent.
The argument should be added also in the ocs-site-config.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman self-requested a review November 7, 2023 21:27
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been talking offline, but just for completeness here, I'd like to move the monitoring in a different direction. This ping doesn't tell us much beyond the host being up. A monitor of the UDP stream (possibly with additional health status packets added) is really what's needed. I'm going to close this PR, and drop references to this task in the sorunlib implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants