Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stimulator thermometer agent. #695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dixilo
Copy link
Contributor

@dixilo dixilo commented Jun 17, 2024

Description

This is a PR to add stimulator thermometer agent.

Motivation and Context

The stimulator is equiped with original thermometer readout based on MAX31856 and MAX31865.
This agent add functionality to read these devices via Industrial I/O subsystem equipped in Linux kernel.

How Has This Been Tested?

The functionality was tested using the actual MAX31856 and MAX31865 devices.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dixilo dixilo requested a review from BrianJKoopman June 17, 2024 05:01
@BrianJKoopman BrianJKoopman added the new agent New OCS agent needs to be created label Oct 3, 2024
Copy link
Contributor

@davidvng davidvng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This looks good overall, just some comments for consistency that are similar to my previous review.

Also double checking that this agent will also run on a dedicated computer that connects to these devices via USB, like the BLHAgent?

docs/agents/stm_thermo.rst Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/drivers.py Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments in addition to @davidvng's.

docs/agents/stm_thermo.rst Outdated Show resolved Hide resolved
socs/agents/stm_thermo/agent.py Outdated Show resolved Hide resolved
docs/agents/stm_thermo.rst Outdated Show resolved Hide resolved
@dixilo
Copy link
Contributor Author

dixilo commented Feb 6, 2025

Also double checking that this agent will also run on a dedicated computer that connects to these devices via USB, like the BLHAgent?

It runs on a dedicated computer (KR260) like BLHAgent.
KR260 has GPIO pins like Raspberry Pis and it will use these pins to read the devices (MAX31856/MAX31865) via SPI protocol (not via USB connection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware: stimulator new agent New OCS agent needs to be created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants