Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScpiPsuAgent: Fix get_output() return value #815

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

BrianJKoopman
Copy link
Member

Description

This PR fixes a bug in the ScpiPsuAgent's get_output() task that always returned that the channel was 'disabled', even if it was enabled.

This was split out from #763.

Motivation and Context

The state was always reported as disabled, even if enabled.

How Has This Been Tested?

Tested on the OCS system in Texas by @CAWNoodle.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

texmexlab and others added 4 commits September 27, 2024 20:31
'disabled'; bluefors agent not recognizing log file types based on
capitalization.
This is just to split the unrelated changes to a separate PR.
@BrianJKoopman BrianJKoopman merged commit 461c1f0 into main Jan 10, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/scpi-psu-bugfix branch January 10, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant