-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create theory section and update tutorials #233
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 80.76% 80.85% +0.09%
==========================================
Files 35 35
Lines 8704 8704
==========================================
+ Hits 7030 7038 +8
+ Misses 1674 1666 -8
Continue to review full report at Codecov.
|
Discretize: Examples (THIS ERROR WAS FIXED): |
Differential Operators (THIS TYPO WAS FIXED) Overall: This is really(!) well done. Congrats! Main point: With each of the discretizations of Div, Grad, Curl after you have shown that you can write this in a matrix vector form, can you include a short section about the dimensions of the matrices and vectors. Restricting comments to a uniform rectangular mesh in hx, hy, hz would be sufficient. This sentence (repeated throughout the text) threw me off. Especially the word "respectively". When I did the derivation for curl I got your result except for a minus sign. Can you please check? |
Interpolation What about saying that the function to be interpolated is defined at a set of nodes. Interpolation to any location within the boundaries of those points is done through linear interpolation. We are unable to extrapolate, that is, to find the value of the function at a location outside that domain. If the nodes for interpolation coincide with the nodes of the mesh then a value can be found at any location in our "volume" ... or something like that.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thanks for all of your work on this @dccowan! This will be a valuable resource. At this stage, I have done a once-over for organization and usability, and thinking about maintenance and if we need to make updates in the future.
With respect to figures:
- could you put any notebooks / code you used to generate those figures in a repo so that we have them archived
- similarly for any hand-made figures, did you use ppt or similar? could you upload those files to the SimPEG google drive? we can create a
documentation
directory to keep them in
With respect to organization / find-ability of content, I made some specific suggestions, which summarize to: can we flatten the tree as much as possible. So in general, under the theory the navigation bar should be
- Page 1
- heading 1 on page 1
- heading 2 on page 1
- ...
- Page 2
- ...
- Page 3
with perhaps the exception of the final heading which groups the examples. I realize this makes the navigation bar a bit longer, but it makes it much easier to navigate + discover content. When we get the new template in place, we will have a bit more flexibility with how we show content and so should be able to collapse the whole "Theory" section which will tighten things up
- :ref:`Examples Gallery <sphx_glr_examples>` | ||
|
||
|
||
Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Curvilinear Meshes:** A tensor mesh where the axes are curvilinear | ||
- **Cylindrical Meshes:** A pseudo-2D mesh for solving 3D problems with perfect symmetry in the radial direction | ||
|
||
.. figure:: ../../images/mesh_types.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have the original notebook used to generate these figures somewhere? If we ever want / need to make updates, this would save us a lot of time to have archived (even if right now these are in a separate, small repo -- as long as we have them)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been keeping the scripts used to make figures with the intent of archiving them eventually. But I wanted to get feedback and finalize the figures first.
- **X, Y and Z faces:** faces which are normal to the orientation of the X, Y and Z axes, respectively. | ||
|
||
|
||
.. figure:: ../../images/cell_locations.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly with these figures, did you use ppt or similar to create them? Could you upload a copy to the SimPEG google drive so we have them for reference?
@@ -0,0 +1,39 @@ | |||
.. _operators_index: | |||
|
|||
Operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to reduce the depth of the tree, I would be inclined to remove this index file and simply have Interpolation, Averaging and Differential Operators at top-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Flattening" of the tree might come naturally when the new doc style is implemented by Joe. I wanted to leave some of the final details of this to the end because we aren't 100% sure what the final look of the website will be yet. The important thing for me is that we avoid lengthy pages and that we try to partition things into easily digestible bites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing to keep in mind is that the theory section currently parallels with the tutorials section. If you flatten or rearrange the content of the theory sections, the tutorials no longer line up.
@@ -0,0 +1,41 @@ | |||
.. _inner_products_index: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again here, I would be inclined to remove this page and bring
- Basic Inner Products
- Isotropic Constitutive Relationships
- Anisotropic Constitutive Relationships
- Inner products with differential operators (renaming from "Differential Operators" to distinguish from the "Operators" section)
- Boundary Conditions (which I think should be at top level either way)
Goals
Access to Temporary Build
Theory sections can be accessed through a temporary website build: https://dccowan.github.io/
Theory Sections
The current theory section of the website is organized as follows. Tutorials have been developed in parallel.
Remaining Items and Questions
References and bibliography: The theory section takes heavily from work published by others. We must make decisions on how we want to reference the source material.
Balancing emphasis on theory, tutorials and API: In highlighting theory and tutorials, we do not want to diminish the presence of the API. How do we keep the API at the forefront of the website while providing easy access to tutorials and theory for those who need it?
Some Action Items