-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 #313
Draft
jcapriot
wants to merge
34
commits into
main
Choose a base branch
from
1.0.0_alpha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
1.0.0 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # discretize/Tests/__init__.py # discretize/View.py # discretize/base/base_mesh.py # discretize/base/base_regular_mesh.py # discretize/base/base_tensor_mesh.py # discretize/cylindrical_mesh.py # discretize/mixins/mesh_io.py # discretize/mixins/mpl_mod.py # discretize/mixins/vtk_mod.py # discretize/operators/differential_operators.py # discretize/operators/inner_products.py # discretize/tensor_mesh.py # discretize/tests.py # discretize/tree_mesh.py # discretize/utils/code_utils.py # discretize/utils/codeutils.py # discretize/utils/coordinate_utils.py # discretize/utils/coordutils.py # discretize/utils/curvilinear_utils.py # discretize/utils/curvutils.py # discretize/utils/interpolation_utils.py # discretize/utils/interputils.py # discretize/utils/matrix_utils.py # discretize/utils/matutils.py # discretize/utils/mesh_utils.py # discretize/utils/meshutils.py
# Conflicts: # discretize/Tests/__init__.py # discretize/View.py # discretize/base/base_mesh.py # discretize/base/base_tensor_mesh.py # discretize/cylindrical_mesh.py # discretize/mixins/mesh_io.py # discretize/mixins/mpl_mod.py # discretize/operators/differential_operators.py # discretize/tensor_mesh.py # discretize/tests.py # discretize/tree_mesh.py # discretize/utils/__init__.py # discretize/utils/code_utils.py # discretize/utils/coordinate_utils.py # discretize/utils/curvilinear_utils.py # discretize/utils/matrix_utils.py # discretize/utils/mesh_utils.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 85.76% 86.19% +0.43%
==========================================
Files 88 80 -8
Lines 18654 18303 -351
Branches 2959 2902 -57
==========================================
- Hits 15998 15776 -222
+ Misses 1996 1925 -71
+ Partials 660 602 -58 ☔ View full report in Codecov by Sentry. |
(will still run PR test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be an ongoing pull request for the 1.0.0 release. Consider it an alpha version of discretize. Right now it mostly just removes all of the code marking items as deprecated.
I'm going to try to keep it updated for changes in the main branch.