Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typos in diagonal_balance warning #387

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix small typos in diagonal_balance warning #387

merged 2 commits into from
Dec 17, 2024

Conversation

santisoler
Copy link
Member

Add missing space between "have" and "previously", fix spelling in "behavior".

Add missing space between "have" and "previously", fix spelling in
"behavior".
@jcapriot
Copy link
Member

Thanks! noticed this myself too the other day.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (9f10381) to head (06a0d47).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          90       90           
  Lines       18616    18616           
  Branches     2103     2103           
=======================================
  Hits        16049    16049           
  Misses       1883     1883           
  Partials      684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jcapriot jcapriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcapriot jcapriot merged commit 9102097 into main Dec 17, 2024
27 checks passed
@jcapriot jcapriot deleted the fix-typo branch December 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants