Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer usage of Buffer.from #88

Closed
wants to merge 2 commits into from

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Dec 22, 2024

This could fix the current problem of the release (see https://github.com/simple-icons/simple-icons/actions/runs/12449683970/job/34766897205).

It could be because of simple-icons/simple-icons#12415, but the other possible failure can be that an icon added in the last release has been removed later, which triggers a warning (see https://github.com/simple-icons/simple-icons/actions/runs/12449683970/job/34766897205#step:3:175).

@mondeja mondeja added the bug Something isn't working label Dec 22, 2024
@mondeja mondeja requested a review from LitoMore December 22, 2024 14:26
@LitoMore
Copy link
Member

LitoMore commented Dec 22, 2024

I found the root cause. I just created another PR to fix it. See #89.

@mondeja mondeja closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants