Skip to content

Commit

Permalink
Switch to alternate repository for JUnitParams
Browse files Browse the repository at this point in the history
The main dependency has a bug where annotations added on test methods
are not forwarded to any test rules (Pragmatists/JUnitParams#151),
which breaks the `ExpectedUnsubscribed` annotation used for hinting to
the `RxErrorsRule` that we expect a certain number of `Completable`
instances to not be subscribed to.

There is a PR to fix it (Pragmatists/JUnitParams#158),
but this has been inactive for over a year, so I forked the repository
and applied the fix myself and published it via Jitpack.
  • Loading branch information
Vinay S Shenoy committed Mar 3, 2020
1 parent bebbebb commit 1cf548c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
6 changes: 1 addition & 5 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ apply plugin: 'io.sentry.android.gradle'

apply from: "../quality/install-git-hook.gradle"

repositories {
maven { url 'https://jitpack.io' }
}

sentry {
autoProguardConfig true
// We can disable auto upload of proguard mappings since we use -dontobfuscate when running proguard
Expand Down Expand Up @@ -212,7 +208,7 @@ dependencies {

testImplementation "junit:junit:$versions.junit"
testImplementation "com.nhaarman:mockito-kotlin:$versions.mockitoKotlin"
testImplementation "pl.pragmatists:JUnitParams:$versions.junitParams"
testImplementation "com.github.vinaysshenoy:JUnitParams:$versions.junitParams"
testImplementation "com.google.truth:truth:$versions.truth"
testImplementation "com.github.blocoio:faker:$versions.faker"

Expand Down
3 changes: 2 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ buildscript {
truth : '1.0',
junit : '4.12',
mockitoKotlin : '1.6.0',
junitParams : '1.1.1',
junitParams : '1.1.2',
sqliteAndroid : '3.24.0',
playServicesAuth : '16.0.1',
playServicesVision : '16.2.0',
Expand Down Expand Up @@ -91,6 +91,7 @@ allprojects {
repositories {
google()
mavenCentral()
maven { url 'https://jitpack.io' }
jcenter()
}
}
Expand Down
5 changes: 1 addition & 4 deletions router/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$versions.kotlin"
implementation "io.reactivex.rxjava2:rxjava:$versions.rxJava"
implementation "com.jakewharton.timber:timber:$versions.timber"
testImplementation "pl.pragmatists:JUnitParams:$versions.junitParams"
testImplementation "com.github.vinaysshenoy:JUnitParams:$versions.junitParams"
testImplementation "com.google.truth:truth:$versions.truth"
}
repositories {
mavenCentral()
}

0 comments on commit 1cf548c

Please sign in to comment.