Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFT1 Group Payment Protocol #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add NFT1 Group Payment Protocol #26

wants to merge 2 commits into from

Conversation

jcramer
Copy link
Contributor

@jcramer jcramer commented Mar 3, 2020

This specification handles an edge case associated with the NFT1 specification. This spec allows merchants to accept payments for any NFT token ID that is part of a certain NFT1 group.

vinarmani
vinarmani reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@vinarmani vinarmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be some explicit mention of the wallet setting the "Accept:" header to both the MIME types for this and for Simple Ledger Payment Protocol. Either that or there needs to be an explicit difference in the non-backwards-compatible URIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinarmani vinarmani vinarmani left review comments

@blockparty-sh blockparty-sh Awaiting requested review from blockparty-sh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcramer @vinarmani