SSP-2066_add_routes_and_controllers #216
php.yml
on: pull_request
Annotations
26 errors and 20 warnings
PossiblyUndefinedArrayOffset:
public/cas.php#L40
public/cas.php:40:20: PossiblyUndefinedArrayOffset: Possibly undefined array key $_SERVER['PATH_INFO'] on array{APP_DEBUG?: bool|string, APP_ENV?: string, AUTH_TYPE?: non-empty-string, CONTENT_LENGTH?: string, CONTENT_TYPE?: string, DOCUMENT_ROOT?: non-empty-string, FCGI_ROLE?: non-empty-string, GATEWAY_INTERFACE?: non-empty-string, HOME?: non-empty-string, HTTPS?: string, HTTP_ACCEPT?: non-empty-string, HTTP_ACCEPT_CHARSET?: non-empty-string, HTTP_ACCEPT_ENCODING?: non-empty-string, HTTP_ACCEPT_LANGUAGE?: non-empty-string, HTTP_CACHE_CONTROL?: non-empty-string, HTTP_CDN_LOOP?: non-empty-string, HTTP_CF_CONNECTING_IP?: non-empty-string, HTTP_CF_IPCOUNTRY?: non-empty-string, HTTP_CF_VISITOR?: non-empty-string, HTTP_CLIENT_IP?: non-empty-string, HTTP_CONNECTION?: non-empty-string, HTTP_COOKIE?: non-empty-string, HTTP_DNT?: non-empty-string, HTTP_HOST?: non-empty-string, HTTP_PRIORITY?: non-empty-string, HTTP_REFERER?: non-empty-string, HTTP_SEC_CH_UA?: non-empty-string, HTTP_SEC_CH_UA_MOBILE?: non-empty-string, HTTP_SEC_CH_UA_PLATFORM?: non-empty-string, HTTP_SEC_FETCH_DEST?: non-empty-string, HTTP_SEC_FETCH_MODE?: non-empty-string, HTTP_SEC_FETCH_SITE?: non-empty-string, HTTP_SEC_FETCH_USER?: non-empty-string, HTTP_UPGRADE_INSECURE_REQUESTS?: non-empty-string, HTTP_USER_AGENT?: non-empty-string, HTTP_X_FORWARDED_FOR?: non-empty-string, HTTP_X_FORWARDED_PROTO?: non-empty-string, HTTP_X_REAL_IP?: non-empty-string, ORIG_PATH_INFO?: non-empty-string, PATH?: non-empty-string, PATH_INFO?: non-empty-string, PATH_TRANSLATED?: non-empty-string, PHP_AUTH_DIGEST?: non-empty-string, PHP_AUTH_PW?: non-empty-string, PHP_AUTH_USER?: non-empty-string, PHP_SELF?: non-empty-string, QUERY_STRING?: string, REDIRECT_REMOTE_USER?: non-empty-string, REDIRECT_STATUS?: non-empty-string, REMOTE_ADDR?: non-empty-string, REMOTE_HOST?: non-empty-string, REMOTE_PORT?: string, REMOTE_USER?: non-empty-string, REQUEST_METHOD?: non-empty-string, REQUEST_SCHEME?: non-empty-string, REQUEST_TIME?: int<1732643747, max>, REQUEST_TIME_FLOAT?: float, REQUEST_URI?: non-empty-string, SCRIPT_FILENAME?: non-empty-string, SCRIPT_NAME?: non-empty-string, SERVER_ADDR?: non-empty-string, SERVER_ADMIN?: non-empty-string, SERVER_NAME?: non-empty-string, SERVER_PORT?: non-empty-string, SERVER_PROTOCOL?: non-empty-string, SERVER_SIGNATURE?: non-empty-string, SERVER_SOFTWARE?: non-empty-string, USER?: non-empty-string, argc?: int<1, max>, argv?: non-empty-list<string>, ...<non-empty-string, string>} (see https://psalm.dev/167)
|
PossiblyNullArgument:
public/cas.php#L40
public/cas.php:40:20: PossiblyNullArgument: Argument 1 of substr cannot be null, possibly null value provided (see https://psalm.dev/078)
|
RiskyTruthyFalsyComparison:
public/login.php#L47
public/login.php:47:40: RiskyTruthyFalsyComparison: Operand of type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
RiskyTruthyFalsyComparison:
public/login.php#L48
public/login.php:48:41: RiskyTruthyFalsyComparison: Operand of type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyInvalidArgument:
public/login.php#L58
public/login.php:58:69: PossiblyInvalidArgument: Argument 1 of sanitize expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
ArgumentTypeCoercion:
public/login.php#L114
public/login.php:114:58: ArgumentTypeCoercion: Argument 2 of SimpleSAML\Module\casserver\Cas\AttributeExtractor::__construct expects SimpleSAML\Module\casserver\Cas\Factories\ProcessingChainFactory, but parent type object provided (see https://psalm.dev/193)
|
PossiblyInvalidArgument:
public/login.php#L187
public/login.php:187:38: PossiblyInvalidArgument: Argument 1 of SimpleSAML\Module\casserver\Cas\AttributeExtractor::manageState expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|string provided (see https://psalm.dev/092)
|
InvalidArgument:
public/login.php#L229
public/login.php:229:14: InvalidArgument: Argument 1 of echo expects string, but array<array-key, mixed> provided (see https://psalm.dev/004)
|
PossiblyInvalidArgument:
public/login.php#L229
public/login.php:229:55: PossiblyInvalidArgument: Argument 2 of casServiceValidate expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|null|string provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
public/login.php#L236
public/login.php:236:65: PossiblyInvalidArgument: Argument 1 of SimpleSAML\Utils\HTTP::addURLParameters expects string, but possibly different type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|null|string provided (see https://psalm.dev/092)
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L277
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.3, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L328
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.3, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.2, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L277
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.2, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L328
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L277
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.2, ubuntu-latest
Process completed with exit code 1.
|
Unit tests, PHP 8.1, ubuntu-latest:
tests/public/LoginIntegrationTest.php#L328
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.1, ubuntu-latest
Process completed with exit code 1.
|
Unit tests, PHP 8.1, windows-latest:
tests/public/LoginIntegrationTest.php#L277
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.1, windows-latest:
tests/public/LoginIntegrationTest.php#L328
Failed asserting that 500 matches expected 200.
|
Unit tests, PHP 8.1, windows-latest
Process completed with exit code 1.
|
Unit tests, PHP 8.2, windows-latest
The job was canceled because "windows-latest_8_1" failed.
|
Unit tests, PHP 8.2, windows-latest
The operation was canceled.
|
Unit tests, PHP 8.3, windows-latest
The job was canceled because "windows-latest_8_1" failed.
|
Unit tests, PHP 8.3, windows-latest
The operation was canceled.
|
DeprecatedFunction:
public/proxy.php#L43
public/proxy.php:43:5: DeprecatedFunction: The function checkserviceurl has been marked as deprecated (see https://psalm.dev/201)
|
DeprecatedFunction:
public/proxy.php#L102
public/proxy.php:102:12: DeprecatedFunction: The function checkserviceurl has been marked as deprecated (see https://psalm.dev/201)
|
PropertyNotSetInConstructor:
src/Cas/Ticket/DelegatingTicketStore.php#L33
src/Cas/Ticket/DelegatingTicketStore.php:33:25: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore::$primaryDelegate is not defined in constructor of SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
src/Controller/Cas10Controller.php#L23
src/Controller/Cas10Controller.php:23:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas10Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas10Controller or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
src/Controller/Cas20Controller.php#L25
src/Controller/Cas20Controller.php:25:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas20Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas20Controller or in any methods called in the constructor (see https://psalm.dev/074)
|
MissingParamType:
src/Controller/Cas20Controller.php#L49
src/Controller/Cas20Controller.php:49:9: MissingParamType: Parameter $ticketStore has no provided type (see https://psalm.dev/154)
|
PropertyNotSetInConstructor:
src/Controller/Cas30Controller.php#L25
src/Controller/Cas30Controller.php:25:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas30Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas30Controller or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
src/Controller/LoginController.php#L32
src/Controller/LoginController.php:32:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LoginController::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\LoginController or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
src/Controller/LoginController.php#L57
src/Controller/LoginController.php:57:21: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LoginController::$idpList is not defined in constructor of SimpleSAML\Module\casserver\Controller\LoginController or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
src/Controller/LoginController.php#L60
src/Controller/LoginController.php:60:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LoginController::$authProcId is not defined in constructor of SimpleSAML\Module\casserver\Controller\LoginController or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L38
tests/public/LoginIntegrationTest.php:38:29: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L43
tests/public/LoginIntegrationTest.php:43:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server_addr is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L48
tests/public/LoginIntegrationTest.php:48:19: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$server_pid is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L53
tests/public/LoginIntegrationTest.php:53:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$shared_file is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/public/LoginIntegrationTest.php#L58
tests/public/LoginIntegrationTest.php:58:22: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\LoginIntegrationTest::$cookies_file is not defined in constructor of SimpleSAML\Casserver\LoginIntegrationTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PossiblyNullArrayAccess:
tests/public/LoginIntegrationTest.php#L215
tests/public/LoginIntegrationTest.php:215:47: PossiblyNullArrayAccess: Cannot access array value on possibly null variable of type array<array-key, SimpleXMLElement>|false|null (see https://psalm.dev/079)
|
PossiblyFalseReference:
tests/public/LoginIntegrationTest.php#L215
tests/public/LoginIntegrationTest.php:215:61: PossiblyFalseReference: Cannot call method xpath on possibly false value (see https://psalm.dev/105)
|
PossiblyNullArrayAccess:
tests/public/LoginIntegrationTest.php#L216
tests/public/LoginIntegrationTest.php:216:45: PossiblyNullArrayAccess: Cannot access array value on possibly null variable of type array<array-key, SimpleXMLElement>|false|null (see https://psalm.dev/079)
|
PossiblyFalseReference:
tests/public/LoginIntegrationTest.php#L216
tests/public/LoginIntegrationTest.php:216:57: PossiblyFalseReference: Cannot call method xpath on possibly false value (see https://psalm.dev/105)
|
PossiblyNullArrayAccess:
tests/public/LoginIntegrationTest.php#L217
tests/public/LoginIntegrationTest.php:217:15: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $authenticationNodeToDeleteExpected of type SimpleXMLElement|null (see https://psalm.dev/079)
|