Skip to content

SSP-2066_add_routes_and_controllers #221

SSP-2066_add_routes_and_controllers

SSP-2066_add_routes_and_controllers #221

Triggered via pull request December 2, 2024 16:49
Status Success
Total duration 3m 1s
Artifacts

php.yml

on: pull_request
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
32s
Code coverage
Cleanup artifacts
3s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 28 warnings
UndefinedDocblockClass: src/Cas/AttributeExtractor.php#L58
src/Cas/AttributeExtractor.php:58:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\Module\casserver\Cas\Exception does not exist (see https://psalm.dev/200)
PossiblyNullArgument: src/Cas/AttributeExtractor.php#L66
src/Cas/AttributeExtractor.php:66:33: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\casserver\Cas\AttributeExtractor::runAuthProcs cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyNullArrayAccess: src/Cas/AttributeExtractor.php#L70
src/Cas/AttributeExtractor.php:70:23: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $state of type array<array-key, mixed>|null (see https://psalm.dev/079)
PossiblyNullArrayAccess: src/Cas/AttributeExtractor.php#L74
src/Cas/AttributeExtractor.php:74:21: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $attributes of type mixed|null (see https://psalm.dev/079)
PossiblyNullArrayAccess: src/Cas/AttributeExtractor.php#L74
src/Cas/AttributeExtractor.php:74:21: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $attributes[$casUsernameAttribute] of type mixed|null (see https://psalm.dev/079)
RiskyTruthyFalsyComparison: src/Cas/AttributeExtractor.php#L75
src/Cas/AttributeExtractor.php:75:13: RiskyTruthyFalsyComparison: Operand of type mixed|null contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
PossiblyNullArgument: src/Cas/AttributeExtractor.php#L86
src/Cas/AttributeExtractor.php:86:49: PossiblyNullArgument: Argument 2 of array_key_exists cannot be null, possibly null value provided (see https://psalm.dev/078)
UndefinedDocblockClass: src/Cas/AttributeExtractor.php#L112
src/Cas/AttributeExtractor.php:112:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\Module\casserver\Cas\Exception does not exist (see https://psalm.dev/200)
UndefinedDocblockClass: src/Cas/AttributeExtractor.php#L113
src/Cas/AttributeExtractor.php:113:16: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\Module\casserver\Cas\Error\UnserializableException does not exist (see https://psalm.dev/200)
RiskyTruthyFalsyComparison: src/Cas/AttributeExtractor.php#L153
src/Cas/AttributeExtractor.php:153:14: RiskyTruthyFalsyComparison: Operand of type mixed|null contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
Security checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Quality control
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
PropertyNotSetInConstructor: src/Cas/Ticket/DelegatingTicketStore.php#L33
src/Cas/Ticket/DelegatingTicketStore.php:33:25: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore::$primaryDelegate is not defined in constructor of SimpleSAML\Module\casserver\Cas\Ticket\DelegatingTicketStore or in any private or final methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Controller/Cas10Controller.php#L23
src/Controller/Cas10Controller.php:23:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas10Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas10Controller or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Controller/Cas20Controller.php#L25
src/Controller/Cas20Controller.php:25:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas20Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas20Controller or in any methods called in the constructor (see https://psalm.dev/074)
MissingParamType: src/Controller/Cas20Controller.php#L49
src/Controller/Cas20Controller.php:49:9: MissingParamType: Parameter $ticketStore has no provided type (see https://psalm.dev/154)
DeprecatedMethod: src/Controller/Cas20Controller.php#L123
src/Controller/Cas20Controller.php:123:21: DeprecatedMethod: The method SimpleSAML\Module\casserver\Controller\Traits\UrlTrait::checkServiceURL has been marked as deprecated (see https://psalm.dev/001)
PropertyNotSetInConstructor: src/Controller/Cas30Controller.php#L25
src/Controller/Cas30Controller.php:25:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\Cas30Controller::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\Cas30Controller or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Controller/LoginController.php#L34
src/Controller/LoginController.php:34:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LoginController::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\LoginController or in any private or final methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Controller/LoginController.php#L59
src/Controller/LoginController.php:59:21: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LoginController::$idpList is not defined in constructor of SimpleSAML\Module\casserver\Controller\LoginController or in any private or final methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Controller/LogoutController.php#L26
src/Controller/LogoutController.php:26:22: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Controller\LogoutController::$logger is not defined in constructor of SimpleSAML\Module\casserver\Controller\LogoutController or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Http/XmlResponse.php#L9
src/Http/XmlResponse.php:9:7: PropertyNotSetInConstructor: Property SimpleSAML\Module\casserver\Http\XmlResponse::$charset is not defined in constructor of SimpleSAML\Module\casserver\Http\XmlResponse or in any methods called in the constructor (see https://psalm.dev/074)
PossiblyUndefinedVariable: tests/src/AttributeExtractorTest.php#L23
tests/src/AttributeExtractorTest.php:23:9: PossiblyUndefinedVariable: Possibly undefined variable $state, first seen on line 23 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/AttributeExtractorTest.php#L49
tests/src/AttributeExtractorTest.php:49:9: PossiblyUndefinedVariable: Possibly undefined variable $state, first seen on line 49 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/AttributeExtractorTest.php#L79
tests/src/AttributeExtractorTest.php:79:9: PossiblyUndefinedVariable: Possibly undefined variable $state, first seen on line 79 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/AttributeExtractorTest.php#L105
tests/src/AttributeExtractorTest.php:105:9: PossiblyUndefinedVariable: Possibly undefined variable $state, first seen on line 105 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/AttributeExtractorTest.php#L145
tests/src/AttributeExtractorTest.php:145:9: PossiblyUndefinedVariable: Possibly undefined variable $state, first seen on line 145 (see https://psalm.dev/018)
PropertyNotSetInConstructor: tests/src/Cas/Protocol/Cas20Test.php#L16
tests/src/Cas/Protocol/Cas20Test.php:16:27: PropertyNotSetInConstructor: Property SimpleSAML\Casserver\Cas20Test::$document is not defined in constructor of SimpleSAML\Casserver\Cas20Test or in any methods called in the constructor (see https://psalm.dev/074)
PossiblyNullArrayAccess: tests/src/Cas/Protocol/Cas20Test.php#L62
tests/src/Cas/Protocol/Cas20Test.php:62:47: PossiblyNullArrayAccess: Cannot access array value on possibly null variable of type array<array-key, SimpleXMLElement>|false|null (see https://psalm.dev/079)
PossiblyFalseReference: tests/src/Cas/Protocol/Cas20Test.php#L62
tests/src/Cas/Protocol/Cas20Test.php:62:61: PossiblyFalseReference: Cannot call method xpath on possibly false value (see https://psalm.dev/105)
PossiblyNullArrayAccess: tests/src/Cas/Protocol/Cas20Test.php#L63
tests/src/Cas/Protocol/Cas20Test.php:63:45: PossiblyNullArrayAccess: Cannot access array value on possibly null variable of type array<array-key, SimpleXMLElement>|false|null (see https://psalm.dev/079)
PossiblyFalseReference: tests/src/Cas/Protocol/Cas20Test.php#L63
tests/src/Cas/Protocol/Cas20Test.php:63:57: PossiblyFalseReference: Cannot call method xpath on possibly false value (see https://psalm.dev/105)
Linter
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests, PHP 8.1, ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests, PHP 8.3, ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit tests, PHP 8.2, ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Code coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Cleanup artifacts
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636