Skip to content

Commit

Permalink
Fix Psalm-issues
Browse files Browse the repository at this point in the history
  • Loading branch information
tvdijen committed Feb 14, 2024
1 parent 0b1e2d2 commit 0eb2712
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions psalm-dev.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<UnresolvableInclude>
<errorLevel type="suppress">
<file name="tests/bootstrap.php" />
<file name="tests/routers/configLoader.php" />
</errorLevel>
</UnresolvableInclude>
</issueHandlers>
Expand Down
4 changes: 2 additions & 2 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
reportMixedIssues="false"
>
<projectFiles>
<directory name="config-templates" />
<directory name="config" />
<directory name="public" />
<directory name="src" />
<directory name="www" />
</projectFiles>

<issueHandlers>
Expand Down
2 changes: 1 addition & 1 deletion src/Cas/Protocol/SamlValidateResponder.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function convertToSaml(array $ticket): Chunk

/**
* @param \SimpleSAML\XML\SerializableElementInterface $samlResponse
* @return \SimpleSAML\XML\SOAP11\XML\env\Envelope
* @return \SimpleSAML\SOAP11\XML\env\Envelope
*/
public function wrapInSoap(SerializableElementInterface $samlResponse): Envelope
{
Expand Down
5 changes: 3 additions & 2 deletions tests/public/LoginIntegrationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace SimpleSAML\Casserver;

use CurlHandle;
use DOMDocument;
use PHPUnit\Framework\TestCase;
use SimpleSAML\Configuration;
Expand Down Expand Up @@ -452,10 +453,10 @@ private function authenticate(): void

/**
* TODO: migrate into BuiltInServer
* @param resource $ch
* @param \CurlHandle $ch
* @return array
*/
private function execAndHandleCurlResponse($ch): array
private function execAndHandleCurlResponse(CurlHandle $ch): array
{
$resp = curl_exec($ch);
if ($resp === false) {
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Cas/Protocol/SamlValidateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function testSamlValidatXmlGeneration(): void

$asSoap = $samlValidate->wrapInSoap($xmlString);

$this->assertInstanceOf($asSoap, Envelope::class);
$this->assertInstanceOf(Envelope::class, $asSoap);
$this->assertNull($asSoap->getHeader());
$this->assertNotEmpty($asSoap->getBody());
}
Expand Down

0 comments on commit 0eb2712

Please sign in to comment.