Replace RunnableResponse with StreamedResponse

simplesamlphp · Aug 21, 2024 · f8828bb · f8828bb
1 parent 581a7ab
commit f8828bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/Controller/DiscoPower.php b/src/Controller/DiscoPower.php
@@ -6,20 +6,17 @@
 
 use Exception;
 use SimpleSAML\Error;
-use SimpleSAML\HTTP\RunnableResponse;
 use SimpleSAML\Module\discopower\PowerIdPDisco;
 use SimpleSAML\Session;
-use Symfony\Component\HttpFoundation\JsonResponse;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\{JsonResponse, Request, Response, StreamedResponse};
 
 class DiscoPower
 {
     /**
      * @param \Symfony\Component\HttpFoundation\Request $request The current request.
-     * @return \SimpleSAML\HTTP\RunnableResponse
+     * @return \Symfony\Component\HttpFoundation\StreamedResponse
      */
-    public function main(Request $request): RunnableResponse
+    public function main(Request $request): StreamedResponse
     {
         try {
             $discoHandler = new PowerIdPDisco(
@@ -32,7 +29,7 @@ public function main(Request $request): RunnableResponse
         }
 
         try {
-            return new RunnableResponse([$discoHandler, 'handleRequest'], []);
+            return new StreamedResponse([$discoHandler, 'handleRequest']);
         } catch (Exception $exception) {
             // An error here should be caused by metadata
             throw new Error\Error('METADATA', $exception);

diff --git a/tests/src/Controller/DiscoPowerTest.php b/tests/src/Controller/DiscoPowerTest.php
@@ -7,11 +7,10 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use SimpleSAML\Configuration;
 use SimpleSAML\Error;
-use SimpleSAML\HTTP\RunnableResponse;
 use SimpleSAML\Module\discopower\Controller;
 use SimpleSAML\Session;
 use SimpleSAML\TestUtils\ClearStateTestCase;
-use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\{Request, StreamedResponse};
 
 /**
  * Set of tests for the controllers in the "discopower" module.
@@ -83,7 +82,7 @@ public function testDiscoPowerHasDiscoParams(): void
         $c = new Controller\DiscoPower();
 
         $r = $c->main($request);
-        $this->assertInstanceOf(RunnableResponse::class, $r);
+        $this->assertInstanceOf(StreamedResponse::class, $r);
         $this->assertTrue($r->isSuccessful());
     }