Skip to content

Fix metarefresh controller: $this->config was missing but is used #158

Fix metarefresh controller: $this->config was missing but is used

Fix metarefresh controller: $this->config was missing but is used #158

Triggered via push October 12, 2023 15:09
Status Success
Total duration 3m 3s
Artifacts 1

php.yml

on: push
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
20s
Code coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
RedundantCondition: src/ARP.php#L39
src/ARP.php:39:13: RedundantCondition: Type string for $attributemap_filename is never null (see https://psalm.dev/122)
PossiblyUndefinedArrayOffset: src/MetaLoader.php#L123
src/MetaLoader.php:123:52: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
PossiblyUndefinedArrayOffset: src/MetaLoader.php#L133
src/MetaLoader.php:133:46: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
PossiblyUndefinedVariable: src/MetaLoader.php#L150
src/MetaLoader.php:150:40: PossiblyUndefinedVariable: Possibly undefined variable $data defined in try block (see https://psalm.dev/018)
ArgumentTypeCoercion: src/MetaLoader.php#L344
src/MetaLoader.php:344:50: ArgumentTypeCoercion: Argument 1 of preg_grep expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
ArgumentTypeCoercion: src/MetaLoader.php#L368
src/MetaLoader.php:368:32: ArgumentTypeCoercion: Argument 1 of preg_match expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
PossiblyInvalidArgument: src/MetaLoader.php#L368
src/MetaLoader.php:368:45: PossiblyInvalidArgument: Argument 1 of strval expects null|object|scalar, but possibly different type array<array-key, mixed>|string provided (see https://psalm.dev/092)
TooManyArguments: src/MetaLoader.php#L674
src/MetaLoader.php:674:24: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandlerPdo::__construct - expecting 1 but saw 2 (see https://psalm.dev/026)
InvalidArgument: src/MetaLoader.php#L674
src/MetaLoader.php:674:63: InvalidArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandlerPdo::__construct expects array<array-key, mixed>, but SimpleSAML\Configuration provided (see https://psalm.dev/004)
TooManyArguments: src/MetaRefresh.php#L71
src/MetaRefresh.php:71:35: TooManyArguments: Too many arguments for method SimpleSAML\Configuration::getvaluevalidate - saw 3 (see https://psalm.dev/026)
PropertyNotSetInConstructor: tests/src/Controller/MetaRefreshTest.php#L26
tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/Controller/MetaRefreshTest.php#L29
tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/Controller/MetaRefreshTest.php#L32
tests/src/Controller/MetaRefreshTest.php:32:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/Controller/MetaRefreshTest.php#L35
tests/src/Controller/MetaRefreshTest.php:35:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
MissingReturnType: tests/src/Controller/MetaRefreshTest.php#L95
tests/src/Controller/MetaRefreshTest.php:95:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)
MissingPropertyType: tests/src/MetaLoaderTest.php#L14
tests/src/MetaLoaderTest.php:14:13: MissingPropertyType: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$metaloader does not have a declared type - consider SimpleSAML\Module\metarefresh\MetaLoader|null (see https://psalm.dev/045)
PropertyNotSetInConstructor: tests/src/MetaLoaderTest.php#L17
tests/src/MetaLoaderTest.php:17:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/MetaLoaderTest.php#L20
tests/src/MetaLoaderTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$tmpdir is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
PossiblyUndefinedVariable: tests/src/MetaLoaderTest.php#L113
tests/src/MetaLoaderTest.php:113:76: PossiblyUndefinedVariable: Variable $metadata must be defined prior to use within an unknown function or method (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/MetaLoaderTest.php#L165
tests/src/MetaLoaderTest.php:165:76: PossiblyUndefinedVariable: Variable $metadata must be defined prior to use within an unknown function or method (see https://psalm.dev/018)

Artifacts

Produced during runtime
Name Size
coverage-data Expired
1.32 MB