Address Psalm issues

simplesamlphp · May 29, 2019 · 4e98678 · 4e98678
1 parent 01d36ef
commit 4e98678
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/lib/Auth/Process/SmartID.php b/lib/Auth/Process/SmartID.php
@@ -45,13 +45,6 @@ class SmartID extends \SimpleSAML\Auth\ProcessingFilter
      */
     private $add_candidate = true;
 
-    /**
-     * Attributes which should be added/appended.
-     *
-     * @var array Associative array of arrays.
-     */
-    private $attributes = [];
-
 
     /**
      * @param array $config
@@ -138,7 +131,7 @@ public function process(&$request)
 
         $id = $this->addID($request['Attributes'], $request);
 
-        if (isset($id)) {
+        if (!empty($id)) {
             $request['Attributes'][$this->id_attribute] = [$id];
         }
     }

diff --git a/lib/Auth/Process/SmartName.php b/lib/Auth/Process/SmartName.php
@@ -12,14 +12,6 @@
  */
 class SmartName extends \SimpleSAML\Auth\ProcessingFilter
 {
-    /**
-     * Attributes which should be added/appended.
-     *
-     * @var array Associative array of arrays.
-     */
-    private $attributes = [];
-
-
     /**
      * @param array $attributes
      * @return string|null