Skip to content

Start using PHP 8.1 features #1014

Start using PHP 8.1 features

Start using PHP 8.1 features #1014

Triggered via push December 14, 2023 20:36
Status Failure
Total duration 2m 4s
Artifacts

php.yml

on: push
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
0s
Code coverage
Cleanup artifacts
0s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

17 errors and 13 warnings
MoreSpecificReturnType: src/Alg/Encryption/EncryptionAlgorithmFactory.php#L78
src/Alg/Encryption/EncryptionAlgorithmFactory.php:78:16: MoreSpecificReturnType: The declared return type 'SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmFactory::getAlgorithm is more specific than the inferred return type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' (see https://psalm.dev/070)
LessSpecificReturnStatement: src/Alg/Encryption/EncryptionAlgorithmFactory.php#L86
src/Alg/Encryption/EncryptionAlgorithmFactory.php:86:16: LessSpecificReturnStatement: The type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' is more general than the declared return type 'SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmFactory::getAlgorithm (see https://psalm.dev/129)
MoreSpecificReturnType: src/Alg/KeyTransport/KeyTransportAlgorithmFactory.php#L68
src/Alg/KeyTransport/KeyTransportAlgorithmFactory.php:68:16: MoreSpecificReturnType: The declared return type 'SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\KeyTransport\KeyTransportAlgorithmFactory::getAlgorithm is more specific than the inferred return type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' (see https://psalm.dev/070)
LessSpecificReturnStatement: src/Alg/KeyTransport/KeyTransportAlgorithmFactory.php#L76
src/Alg/KeyTransport/KeyTransportAlgorithmFactory.php:76:16: LessSpecificReturnStatement: The type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' is more general than the declared return type 'SimpleSAML\XMLSecurity\Alg\Encryption\EncryptionAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\KeyTransport\KeyTransportAlgorithmFactory::getAlgorithm (see https://psalm.dev/129)
MoreSpecificReturnType: src/Alg/Signature/SignatureAlgorithmFactory.php#L79
src/Alg/Signature/SignatureAlgorithmFactory.php:79:16: MoreSpecificReturnType: The declared return type 'SimpleSAML\XMLSecurity\Alg\Signature\SignatureAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\Signature\SignatureAlgorithmFactory::getAlgorithm is more specific than the inferred return type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' (see https://psalm.dev/070)
LessSpecificReturnStatement: src/Alg/Signature/SignatureAlgorithmFactory.php#L87
src/Alg/Signature/SignatureAlgorithmFactory.php:87:16: LessSpecificReturnStatement: The type 'SimpleSAML\XMLSecurity\Alg\AlgorithmInterface' is more general than the declared return type 'SimpleSAML\XMLSecurity\Alg\Signature\SignatureAlgorithmInterface' for SimpleSAML\XMLSecurity\Alg\Signature\SignatureAlgorithmFactory::getAlgorithm (see https://psalm.dev/129)
PropertyNotSetInConstructor: src/Backend/OpenSSL.php#L52
src/Backend/OpenSSL.php:52:19: PropertyNotSetInConstructor: Property SimpleSAML\XMLSecurity\Backend\OpenSSL::$blocksize is not defined in constructor of SimpleSAML\XMLSecurity\Backend\OpenSSL or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: src/Backend/OpenSSL.php#L55
src/Backend/OpenSSL.php:55:19: PropertyNotSetInConstructor: Property SimpleSAML\XMLSecurity\Backend\OpenSSL::$keysize is not defined in constructor of SimpleSAML\XMLSecurity\Backend\OpenSSL or in any methods called in the constructor (see https://psalm.dev/074)
ArgumentTypeCoercion: src/Backend/OpenSSL.php#L101
src/Backend/OpenSSL.php:101:43: ArgumentTypeCoercion: Argument 1 of SimpleSAML\XMLSecurity\Utils\Random::generateRandomBytes expects int<1, max>, but parent type false|int provided (see https://psalm.dev/193)
PossiblyNullArrayAccess: src/CryptoEncoding/PEM.php#L118
src/CryptoEncoding/PEM.php:118:22: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $e of type array{file: string, line: int, message: string, type: int}|null (see https://psalm.dev/079)
InvalidArgument: tests/XML/ds/CanonicalizationMethodTest.php#L48
tests/XML/ds/CanonicalizationMethodTest.php:48:62: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\CanonicalizationMethod::__construct expects SimpleSAML\XMLSecurity\C14N, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
InvalidArgument: tests/XML/ds/ManifestTest.php#L61
tests/XML/ds/ManifestTest.php:61:35: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\Transform::__construct expects SimpleSAML\XMLSecurity\C14N|string, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
InvalidArgument: tests/XML/ds/ReferenceTest.php#L59
tests/XML/ds/ReferenceTest.php:59:35: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\Transform::__construct expects SimpleSAML\XMLSecurity\C14N|string, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
InvalidArgument: tests/XML/ds/ReferenceTest.php#L84
tests/XML/ds/ReferenceTest.php:84:35: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\Transform::__construct expects SimpleSAML\XMLSecurity\C14N|string, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
InvalidArgument: tests/XML/ds/SignedInfoTest.php#L54
tests/XML/ds/SignedInfoTest.php:54:40: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\CanonicalizationMethod::__construct expects SimpleSAML\XMLSecurity\C14N, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
InvalidArgument: tests/XML/ds/TransformTest.php#L63
tests/XML/ds/TransformTest.php:63:13: InvalidArgument: Argument 1 of SimpleSAML\XMLSecurity\XML\ds\Transform::__construct expects SimpleSAML\XMLSecurity\C14N|string, but enum(SimpleSAML\XMLSecurity\Alg\C14N::EXCLUSIVE_WITHOUT_COMMENTS) provided (see https://psalm.dev/004)
Quality control
Process completed with exit code 2.
PossiblyNullOperand: src/Key/PublicKey.php#L124
src/Key/PublicKey.php:124:25: PossiblyNullOperand: Cannot concatenate with a possibly null null|string (see https://psalm.dev/080)
PossiblyNullOperand: src/Key/PublicKey.php#L128
src/Key/PublicKey.php:128:33: PossiblyNullOperand: Cannot concatenate with a possibly null null|string (see https://psalm.dev/080)
PossiblyNullOperand: src/Key/PublicKey.php#L129
src/Key/PublicKey.php:129:35: PossiblyNullOperand: Cannot concatenate with a possibly null null|string (see https://psalm.dev/080)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L55
tests/Alg/Signature/HMACSignatureTest.php:55:81: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L61
tests/Alg/Signature/HMACSignatureTest.php:61:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L68
tests/Alg/Signature/HMACSignatureTest.php:68:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L75
tests/Alg/Signature/HMACSignatureTest.php:75:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L83
tests/Alg/Signature/HMACSignatureTest.php:83:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/HMACSignatureTest.php#L88
tests/Alg/Signature/HMACSignatureTest.php:88:81: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/RSASignatureTest.php#L62
tests/Alg/Signature/RSASignatureTest.php:62:25: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/RSASignatureTest.php#L72
tests/Alg/Signature/RSASignatureTest.php:72:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/RSASignatureTest.php#L81
tests/Alg/Signature/RSASignatureTest.php:81:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)
PossiblyFalseArgument: tests/Alg/Signature/RSASignatureTest.php#L90
tests/Alg/Signature/RSASignatureTest.php:90:21: PossiblyFalseArgument: Argument 1 of bin2hex cannot be false, possibly string value expected (see https://psalm.dev/104)