CU-86drpncxu - Adicionar um comportamento novo no setMetaData #11
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @public(name="setMetaData") | ||
| def set_meta_data(script_hash: UInt160, property_name: str, value: str) -> bool: | ||
| @public(name="setMetadata") | ||
| def set_owner_and_metadata(owner: UInt160, contract_script_hash: UInt160, property_name: str, value: str) -> bool: |
There was a problem hiding this comment.
The function name set_owner_and_metadata is not very descriptive. Consider renaming it to something more specific, like set_contract_owner_and_metadata.
| has_ownership = set_ownership(contract_script_hash, owner) | ||
|
|
||
| if not has_ownership: | ||
| raise Exception('No authorization') |
There was a problem hiding this comment.
The exception message 'No authorization' is not very descriptive. Consider changing it to 'Failed to set ownership: No authorization'.
|
|
||
| return set_metadata(contract_script_hash, property_name, value) | ||
|
|
||
| @public(name="setMetadata") |
There was a problem hiding this comment.
The function name setMetadata is used twice. Consider renaming one of the functions to avoid confusion.
| contractScriptHash, | ||
| contractOwner: user.account.scriptHash, | ||
| }) | ||
| assert(userCanChangeOwnership) | ||
| }) | ||
|
|
||
| it('Tests canChangeMetaData with verify method', async () => { | ||
| it('Tests canChangeMetadata with verify method', async () => { |
There was a problem hiding this comment.
Please ensure that the function canChangeMetadata exists and is correctly implemented, as the original function was canChangeMetaData.
| const user = wallets.find((wallet: any) => wallet.name === 'user') | ||
| const iconDappUser = await getSdk(user.account) | ||
|
|
||
| const {stdout} = await exec(`neoxp contract get "verifiable" -i ${neoXpInstancePath}`) | ||
| const contractScriptHash = JSON.parse(stdout)[0].hash | ||
|
|
||
| // user is checking if they can change ownership of the smart contract without adding the contract as a signer | ||
| const userCanChangeOwnershipNoSigner = await iconDappUser.canChangeMetaData({ | ||
| const userCanChangeOwnershipNoSigner = await iconDappUser.canChangeMetadata({ | ||
| contractScriptHash, | ||
| contractOwner: user.account.scriptHash, | ||
| }) | ||
| assert(userCanChangeOwnershipNoSigner === false ) |
There was a problem hiding this comment.
Consider using assert.strictEqual(userCanChangeOwnershipNoSigner, false) for a strict equality check.
| contractScriptHash, | ||
| contractOwner: user.account.scriptHash, | ||
| }) | ||
| assert(userCanChangeOwnershipNoSigner === false ) | ||
|
|
||
| // user is checking if they can change ownership of the smart contract | ||
| const userCanChangeOwnership = await iconDappUser.canChangeMetaData( | ||
| const userCanChangeOwnership = await iconDappUser.canChangeMetadata( | ||
| { | ||
| contractScriptHash, | ||
| contractOwner: user.account.scriptHash, |
There was a problem hiding this comment.
The method canChangeMetadata is being called with the same parameters twice. If the result is expected to be different, please ensure the state is correctly modified between the calls.
| @@ -652,7 +761,7 @@ describe('Basic IconDapp Test Suite', function () { | |||
| assert.strictEqual(icons.some(icon => icon.scriptHash==="0x48c40d4666f93408be1bef038b6722404d9a4c2a"), true) | |||
| assert.strictEqual(icons.some(icon => icon.scriptHash==="0xf15976ea5c020aaa12b9989aa9880e990eb5dcc9"), true) | |||
|
|
|||
| const txid = await iconDapp.setMetaData({ | |||
| const txid = await iconDapp.setMetadata({ | |||
There was a problem hiding this comment.
Please ensure that the method name change from setMetaData to setMetadata is reflected throughout the codebase to maintain consistency and avoid potential errors.
| @@ -686,7 +795,7 @@ describe('Basic IconDapp Test Suite', function () { | |||
| assert.strictEqual(icons.some(icon => icon.scriptHash==="0x48c40d4666f93408be1bef038b6722404d9a4c2a"), true) | |||
| assert.strictEqual(icons.some(icon => icon.scriptHash==="0xf15976ea5c020aaa12b9989aa9880e990eb5dcc9"), true) | |||
|
|
|||
| const txid = await iconDapp.setMetaData({ | |||
| const txid = await iconDapp.setMetadata({ | |||
There was a problem hiding this comment.
The method name has been changed from setMetaData to setMetadata. Please ensure that this change is reflected everywhere in the code where this method is called to avoid any potential errors.
No description provided.