Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stages interfaces and makes Dora the default abstract format #1

Draft
wants to merge 1 commit into
base: feature/get-address-abstracts
Choose a base branch
from
Draft

stages interfaces and makes Dora the default abstract format #1

wants to merge 1 commit into from

Conversation

lllwvlvwlll
Copy link

@lllwvlvwlll lllwvlvwlll commented Jul 15, 2021 •
edited
Loading

This PR implements a number of changes to the handling of the neon-api package. In order of importance:

  • Aligns AddressAbstract with the correct API syntax AddressAbstracts
  • Updates the AddressAbstracts interface to set Dora as the default response format with Neoscan using a modified version to ensure cleaner code after Neoscan EoL
  • Migrates interfaces which are not a response to their own files (we need to refactor the entire package to align with the state of the ecosystem...in another PR)
  • Updates Interface names for clarity
  • Aligns code architecture with regards to the response handling and interfaces
  • Updates spacing for consistancy

Do Not Merge ; Pending Checkout

@lllwvlvwlll lllwvlvwlll marked this pull request as draft July 15, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lllwvlvwlll