Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test folder creation via processDirectoryStructure() #4

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

eduardosancho
Copy link
Collaborator

@eduardosancho eduardosancho commented Jun 30, 2022

What was done in this PR by @eduardosancho 🎃 :

Closes issues #1, #2 , #3
Once again, thanks for the detailed instructions on all of the issues, it has been truly useful.

  • Add test to check if testfiles/empty-dir was created.
  • Add test to check if testfiles/content-dir/content-from-ftp was created and log where it's contents come from.

Questions

  • How can I fix an error when trying to access data to the AWS S3?

The first test that checks the entire structure of /testfiles, returns the following error message for AWS S3 which causes other error messages down the line saying "No such file or directory" when looking for any sourcePath pointing to AWS S3.
image

Also, it's expect has been hardcoded to always pass the test.

  • Could you please provide insights on how to test the downloaded content of /content-from-ftp?

The test to verify that /content-from-ftp folder was created successfully is not checking the content of the folder in /testfiles, instead it's dependent on the success message that is returned.
I'm currently trying to use Watch Plugins for this.


@jeanlescure
Copy link
Contributor

Awesome, thank you @eduardosancho , let's see...

How can I fix an error when trying to access data to the AWS S3?

You can add the must-skip flag to the directory definition for S3 locally. S3 is out of the scope of the assigned issues 🙂

Could you please provide insights on how to test the downloaded content of /content-from-ftp?

You can start simple, for example, checking the directory exists, then using a library like glob you can get the tree of files inside the directory, and expect that the length of the file list array is greater than 2

@eduardosancho
Copy link
Collaborator Author

Thanks for the thorough insights.

Update

The test for content-from-ftp now verifies that it contains files and no longer depends only on the success message returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants