Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/small screen warning #539

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix/small screen warning #539

merged 3 commits into from
Jun 25, 2024

Conversation

meganrm
Copy link
Contributor

@meganrm meganrm commented Jun 25, 2024

Time estimate or Size

How long do you expect it to take a reviewer to review this PR?
xsmall

Problem

closes #536

Solution

check for the embed pathname
I also fixed an warning in the console that was caused by not having done called in a logic

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. npm start
  2. make your window small
  3. go to http://localhost:9001/embed?trajFileName=springsalad_condensate_formation_Above_Ksp.simularium
  4. you shouldn't see a warning
  5. go to http://localhost:9001/viewer?trajFileName=springsalad_condensate_formation_Above_Ksp.simularium
  6. you should see a warning

@meganrm meganrm requested a review from a team as a code owner June 25, 2024 17:28
@meganrm meganrm requested review from interim17, ShrimpCryptid and blairlyons and removed request for a team and interim17 June 25, 2024 17:28
Copy link

github-actions bot commented Jun 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
66.26% (-0.07% 🔻)
644/972
🟡 Branches 65.73% 94/143
🔴 Functions 35.1% 86/245
🟡 Lines
64.65% (-0.07% 🔻)
576/891
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / logics.ts
15.86% (-0.07% 🔻)
0% 0%
16.22% (-0.07% 🔻)

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 3b9cfae

@meganrm meganrm merged commit 0b34407 into main Jun 25, 2024
6 checks passed
@meganrm meganrm deleted the fix/small-screen-warning branch June 25, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No small screens popup in embeds
3 participants