Retain previous trajectory state when cancelling autoconversion #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into fix/previous-file-state
interim17
requested review from
meganrm and
ShrimpCryptid
and removed request for
a team
Coverage report
Test suite run success104 tests passing in 7 suites. Report generated by 🧪jest coverage report action from b5bec2a |
ShrimpCryptid
approved these changes
Jun 26, 2024
meganrm
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
tiny, less than 5 min
Problem
Closes #525
Solution
This issue was caused by having multiple websocket connections open during conversion, something @ascibisz fixed a while back.
So we can just stop clearing out the old trajectory when cancelling conversion and it should work fine.