-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conversion title #559
Conversation
…ing data after conversion complete
… into feature/conversion-title
Coverage report
Show files with reduced coverage 🔻
Test suite run success121 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 3fa65a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we care about the overall test coverage going down? Should there be tests for e.g. the reducer.ts
and logics.ts
changes?
Talked to Dan about this and at least for now he seems to feel comfortable with overall coverage dropping below the previous threshold. |
Time estimate or Size
small
Will get review at UX office hours prior to merging, code ready for review.
Problem
Advances #396
Closes: #509
Solution
UI for input, and optional property on
ConversionProcessingData
for title.Small tweaks to the naming of
fileName
andbackendFileName
for clarity in the file conversion logic.Steps to Verify:
(Tip: logging the data on line 271 in
ViewerPanel.tsx
inhandleIncomingConvertedFile
)Screenshots (optional):