[player] Fix string temporaries and warnings #10665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aft#10659) Currently the various systems we use to parse spell data effects act upon simc object such as `player_t`, `action_t`, `buff_t`. This can lead to several issues including but not limited to: order of operation dependence for values that have both flat add and pct mul applied, implementation dependence when simc objects use different dbc data for the same object value, effect modifying effect requiring individual manual implementation, easy-to-miss unexpected effects in possibly unrelated passives being missed, and others. The new system directly modifies the player-specific DBC that is currently used for hotfixes, spell data overrides, and trait effect value modification from trait ranks. As these modifications are directly applied to `spell_data_t`, `spelleffect_data_t`, and `spellpower_data_t` they integrate transparently with all existing dbc data access methods and are agnostic to simc object implementations. For effects that don't directly modify the DBC but instead a base attribute of the object, modifications are pre-registered then applied to the object's base members during construction, either directly or via methods such as `action_t::parse_spell_data()`. **`player_t::parse_passive_effects( const spell_data_t* )`** is the main entry point. Only spells with the `SX_PASSIVE` flag will be parsed, unless `true` is passed as an optional second argument. Since modifications are directly made onto the DBC (or pre-registered) it's not necessary to wait until object construction to parse, but it is recommended you wait until various named class module spell_t pointer structs are populated by the end of `init_spells()`. **`player_t::get_passive_value( const spell_data_t&, string )`** **`player_t::get_passive_value( const spelleffect_data_t&, string )`** **`player_t::get_passive_value( const spellpower_data_t&, string )`** These are used to get the final modified value from the modified DBC for the stat specified. Stat strings can be found in `field_type_map` in player.cpp. A 3-value array will be returned, representing `{ original, flat add, pct mult }`. Variables of type `parsed_value_t<T>` can directly be assigned this array. **`player_t::parse_all_class_passives()`** will automatically parse all class/spec auras, including additional ones added beyond the first. The table of auras can be found in `_class_passives` in `sc_const_data.cpp`. **`player_t::parse_all_passive_talents()`** will automatically parse all talents active for the current player, including those from the trait hash, manual talent strings, and enable_all_talents. **`player_t::parse_all_passive_sets()`** will automatically parse all tier set bonuses for the current expansion. It is recommended you call these three functions for both convenience and to ensure that no errant effects are missed. **`player_t::deregister_passive_effects( const spell_data_t* )`** will retroactively remove any existing parsing of the spell and prevent all future parsing of the spell. **`player_t::register_passive_effect_mask( const spell_data_t*, effect_mask_t )`** will allow you to filter out which effects to be parsed. It uses the same `effect_mask_t` syntax used in `parse_effects()`. This will retroactively adjust any existing parsing of the spell. If the spell has not been parsed yet, `parse_passive_effects()` will still need to be called. ``` // skip effect#1 and effect#5 of the spec spell register_passive_effect_mask( spec_spell, effect_mask_t( true ).disable( 1, 5 ) ) ``` **`player_t::register_passive_affect_list( const spell_data_t*, affect_list_t )`** will allow you to modify which spells are affected by the parsed spell. It uses the same `affect_list_t` syntax used in `parse_effects()`. This will retroactively adjust any existing parsing of the spell. If the spell has not been parsed yet, `parse_passive_effects()` will still need to be called. ``` // also apply family flag 2 to effect#1 of the spec spell register_passive_affect_list( spec_spell, affect_list_t( 1 ).add_family( 2 ) ) ``` **`player_t::register_passive_spell_override( const spell_data_t&, value, field )`** **`player_t::register_passive_power_override( const spellpower_data_t& value[, field = "cost" ] )`** **`player_t::register_passive_effect_override( const spelleffect_data_t&, value[, field = "base_value"] )`** provides a method within the scope of `player_t` that you can use to directly override the values. Unlike the hotfix system, this can be called as a normal `player_t` method allowing you to use any conditional flows as needed. As this directly manipulates the DBC without any processing, it should be called before any other parse methods are used. **`player_t::disable_class_spell_auto_cloning`** default `false`. To remain agnostic from order of operations, by default all class spells are cloned into the player DBC when spell_data_t pointers are called via `find_spell()` and related methods. By setting this to `true` you can disable this auto cloning. Be warned that this will means that all spell_data_t pointers before parsing will point to the base unmodified DBC, and any modifications from parsing will not apply to values retrieved from those early pointers.
* [Player] Automatically Parse Passive Player Auras Includes every aura subtype currently utilized in any class module, as well as every aura subtype supported by the Parse Effects mixin. Reporting is output in the debug log, as well as under `parsed passive effects` in the HTML report, and will output for every effect subtype, with School, Attribute and Rating modifiers providing extra outputs for every affected type.
* [monk] Clean up Assisted Combat APLs for testing. * [monk] Get BrM and WW into a runnable state. * [monk] Unify Celestial Conduit implementation. * [monk] Fix obviously incorrect spell data. * [monk] Fix error and clean up warnings.
… all strings are defined.
|
oops wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::string_viewtemporary.std::string_viewtemporaries and make sure all strings are defined.