[shaman] Ascendance changes for PTR #9462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfarr
force-pushed
the
elemental-ascendance-ptr
branch
from
1c827e7
to
68fa1ed
Compare
53 tasks
This spell has been removed entirely on the PTR
This should avoid creating some duplicates in _certain_ situations. This still leaves implementation for Chain Lightning MIA.
wfarr
force-pushed
the
elemental-ascendance-ptr
branch
from
2912759
to
ebe04fc
Compare
Fix non-chained base spells to guarantee an overload during ascendance on the PTR
wfarr
force-pushed
the
elemental-ascendance-ptr
branch
from
ebe04fc
to
b154d37
Compare
|
Opting to merge this as-is. The tracking issue #9463 details the remaining work to be done, but this covers most of the Ascendance implementation for single-target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cover nearly all the Ascendance changes for PTR, modulo the Flame Shock spreading.
Note: I fully suspect the implementation of how I did the +1 Overloads to maybe be Weird(TM) with Chained Lightning, but that can be dealt with later I think.