[Assassination] Slight Trinket Fix #9545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the logic is tightly timed, the buff.remains on treacherous transmitter tasks seem to be timing out, but checks are needed especially for aoe simulations. remains<1 is a stopgap to fix the timing issue and seems realistic to play, but should be pulled back once the trinket buffs are being accounted for accurately in simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the logic is tightly timed, the buff.remains on treacherous transmitter tasks seem to be timing out much earlier than intended, but the checks are needed especially for aoe simulations.
remains<1 is a stopgap to fix the timing issue and seems realistic to play off of samples, but it should be pulled back to <4 once the trinket buffs are being accounted for accurately in simulations and the buffs are assessed correctly