Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dangling reference warning #9555

Closed
wants to merge 1 commit into from
Closed

fix dangling reference warning #9555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions engine/dbc/spell_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,8 @@ const spell_data_t* spell_data_t::find( util::string_view name, bool ptr )
const spelleffect_data_t& spell_data_t::find_spelleffect( const spell_data_t& spell, effect_type_t type,
effect_subtype_t subtype, int misc )
{
for ( const auto& e : spell.effects() )
const auto effects = spell.effects();
for ( const auto& e : effects )
{
if ( e.type() == type && ( subtype == A_MAX || e.subtype() == subtype ) &&
( misc == std::numeric_limits<int>::min() || e.misc_value1() == misc ) )
Expand All @@ -710,7 +711,8 @@ const spelleffect_data_t& spell_data_t::find_spelleffect( const spell_data_t& sp
const spelleffect_data_t& spell_data_t::find_spelleffect( const spell_data_t& spell, const spell_data_t& affected,
effect_type_t type, effect_subtype_t subtype, int misc )
{
for ( const auto& e : spell.effects() )
const auto effects = spell.effects();
for ( const auto& e : effects )
{
if ( e.type() == type && ( subtype == A_MAX || e.subtype() == subtype ) &&
( misc == std::numeric_limits<int>::min() || e.misc_value1() == misc ) && affected.affected_by_all( e ) )
Expand Down