-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llm): fix azure token provider signature #810
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- pandasai/llm/azure_openai.py (2 hunks)
Additional comments: 1
pandasai/llm/azure_openai.py (1)
- 12-18: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [152-152]
The
_client_params
method should be reviewed to ensure that it correctly handles theazure_ad_token_provider
now that it is a callable. If the callable needs to be invoked to get the token, this method should be updated accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 88 88
Lines 3828 3828
=======================================
Hits 3257 3257
Misses 571 571 ☔ View full report in Codecov by Sentry. |
7e91c2c
to
297b3a9
Compare
@mspronesti thanks a lot, merging :) |
Hi @gventuri, this PR introduces just a minor fix to the signature of the
azure_ad_token_provider
parameter.Summary by CodeRabbit