-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/deserialization of callback events #92
Conversation
* message inbound * contact create
The updates in this PR are going to the right direction, but in the current state, it's difficult to provide an approval:
|
Thanks for the review!
Updated, it is more clear?
Updated the description, it's more clear? |
Added unit tests for each webhook, fixing the models alongside. Json data is based on our Java SDK https://github.com/sinch/sinch-sdk-java/tree/main/openapi-contracts/src/test/resources/domains/conversation/v1/webhooks/events Removed sms verification oas test. The idea is to get rid of all tests based on open api file as they are deemed flakey - the work is ongoing |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check pending comments that are still not answered. On my side:
https://tickets.sinch.com/browse/DEVEXP-622
Adds
Conversation.Webhooks.Deserialize.ParseEvent(string)
method to deserialize hooks models.For
Conversation
unit tests, use the sameJsonSerializationOptions
as insideConversationClient
to be sure of serialization consistencyUpdate
Conversation.Webhooks.Update
method to take first paramater as an Id of of a webhook