Merge pull request #67 from sinch/DEVEXP-312-rename-getNumbers-to-lis…

…tNumbers refactor: Rename voice.applications.getNumbers to voice.applications.listNumbers
sinch · Mar 18, 2024 · 06b2b5c · 06b2b5c
2 parents 43b990f + d70a07d
commit 06b2b5c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/client/src/main/com/sinch/sdk/domains/voice/ApplicationsService.java b/client/src/main/com/sinch/sdk/domains/voice/ApplicationsService.java
@@ -18,7 +18,7 @@ public interface ApplicationsService {
    * @return Your numbers
    * @since 1.0
    */
-  AssignedNumbers getNumbers();
+  AssignedNumbers listNumbers();
 
   /**
    * Returns any callback URLs configured for the specified application

diff --git a/client/src/main/com/sinch/sdk/domains/voice/adapters/ApplicationsService.java b/client/src/main/com/sinch/sdk/domains/voice/adapters/ApplicationsService.java
@@ -31,7 +31,7 @@ protected ApplicationsApi getApi() {
     return this.api;
   }
 
-  public AssignedNumbers getNumbers() {
+  public AssignedNumbers listNumbers() {
 
     return ApplicationsDtoConverter.convert(getApi().configurationGetNumbers());
   }

diff --git a/client/src/test/java/com/sinch/sdk/domains/voice/adapters/ApplicationsServiceTest.java b/client/src/test/java/com/sinch/sdk/domains/voice/adapters/ApplicationsServiceTest.java
@@ -57,7 +57,7 @@ void getNumbers() throws ApiException {
 
     when(api.configurationGetNumbers()).thenReturn(ApplicationsGetNumbersResponseDtoTest.expected);
 
-    AssignedNumbers response = service.getNumbers();
+    AssignedNumbers response = service.listNumbers();
 
     Assertions.assertThat(response)
         .usingRecursiveComparison()

diff --git a/sample-app/README.md b/sample-app/README.md
@@ -135,7 +135,7 @@ See https://developers.sinch.com for details about these parameters
 |              | Update             | [com.sinch.sample.voice.calls.Update](src/main/java/com/sinch/sample/voice/calls/Update.java)                                       | Require `CONFERENCE_ID`  & `CALL_ID` parameters           | 
 |              | ManageWithCallLeg  | [com.sinch.sample.voice.calls.ManageWithCallLeg](src/main/java/com/sinch/sample/voice/calls/ManageWithCallLeg.java)                 | Require `CONFERENCE_ID`  & `CALL_ID` parameters           | 
 | Applications | GetCallbackUrls    | [com.sinch.sample.voice.applications.GetCallbackUrls](src/main/java/com/sinch/sample/voice/applications/GetCallbackUrls.java)       | Require `APPLICATION_API_KEY` parameter                   | 
-|              | GetNumbers         | [com.sinch.sample.voice.applications.GetNumbers](src/main/java/com/sinch/sample/voice/applications/GetNumbers.java)                 |                                                           | 
+|              | GetNumbers         | [com.sinch.sample.voice.applications.ListNumbers](src/main/java/com/sinch/sample/voice/applications/GetNumbers.java)                 |                                                           | 
 |              | QueryNumber        | [com.sinch.sample.voice.applications.QueryNumber](src/main/java/com/sinch/sample/voice/applications/QueryNumber.java)               | Require `PHONE_NUMBER` parameter                          | 
 |              | UnassignNumber     | [com.sinch.sample.voice.applications.UnassignNumber](src/main/java/com/sinch/sample/voice/applications/UnassignNumber.java)         | Require `APPLICATION_API_KEY` & `PHONE_NUMBER` parameters | 
 |              | UpdateCallbackUrls | [com.sinch.sample.voice.applications.UpdateCallbackUrls](src/main/java/com/sinch/sample/voice/applications/UpdateCallbackUrls.java) | Require `APPLICATION_API_KEY` parameter                   | 

diff --git a/...sample/voice/applications/GetNumbers.java → ...ample/voice/applications/ListNumbers.java b/...sample/voice/applications/GetNumbers.java → ...ample/voice/applications/ListNumbers.java
@@ -4,15 +4,15 @@
 import java.io.IOException;
 import java.util.logging.Logger;
 
-public class GetNumbers extends BaseApplication {
+public class ListNumbers extends BaseApplication {
 
-  private static final Logger LOGGER = Logger.getLogger(GetNumbers.class.getName());
+  private static final Logger LOGGER = Logger.getLogger(ListNumbers.class.getName());
 
-  public GetNumbers() throws IOException {}
+  public ListNumbers() throws IOException {}
 
   public static void main(String[] args) {
     try {
-      new GetNumbers().run();
+      new ListNumbers().run();
     } catch (Exception e) {
       LOGGER.severe(e.getMessage());
       e.printStackTrace();
@@ -23,7 +23,7 @@ public void run() {
 
     LOGGER.info("Get assigned numbers");
 
-    var response = client.voice().applications().getNumbers();
+    var response = client.voice().applications().listNumbers();
 
     LOGGER.info("Response: " + response);
   }