refactor: SMS context enable undefined region and default value is ma…

…naged by SinchClient
sinch · Feb 28, 2024 · 1f0d3ed · 1f0d3ed
1 parent a5aaeaa
commit 1f0d3ed
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 18 deletions.
diff --git a/client/src/main/com/sinch/sdk/models/SmsContext.java b/client/src/main/com/sinch/sdk/models/SmsContext.java
@@ -9,8 +9,8 @@ public class SmsContext {
   private final SMSRegion smsRegion;
   private final String smsUrl;
 
-  public SmsContext(SMSRegion smsRegion, String smsUrl) {
-    this.smsRegion = null == smsRegion ? SMSRegion.US : smsRegion;
+  private SmsContext(SMSRegion smsRegion, String smsUrl) {
+    this.smsRegion = smsRegion;
     this.smsUrl = smsUrl;
   }
 

diff --git a/client/src/test/java/com/sinch/sdk/SinchClientTest.java b/client/src/test/java/com/sinch/sdk/SinchClientTest.java
@@ -34,6 +34,15 @@ void defaultSmsUrlAvailable() {
     assertNotNull(client.getConfiguration().getSmsContext().get().getSmsUrl());
   }
 
+  @Test
+  void defaultSmsRegion() {
+    Configuration configuration =
+        Configuration.builder().setKeyId("foo").setKeySecret("foo").setProjectId("foo").build();
+    SinchClient client = new SinchClient(configuration);
+    System.out.println(client.getConfiguration().getSmsContext().get().getSmsRegion());
+    assertNotNull(client.getConfiguration().getSmsContext().get().getSmsRegion());
+  }
+
   @Test
   void defaultVerificationUrlAvailable() {
     Configuration configuration =

diff --git a/client/src/test/java/com/sinch/sdk/models/SmsContextTest.java b/client/src/test/java/com/sinch/sdk/models/SmsContextTest.java