Skip to content

Commit

Permalink
style: Upgrade google code format to 1.22 (supporting java 21 style)
Browse files Browse the repository at this point in the history
  • Loading branch information
JPPortier committed Jul 3, 2024
1 parent 2afc0b8 commit ea1d2a1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '21'
distribution: 'temurin'
cache: maven
- name: Build with Maven
Expand Down
9 changes: 2 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,9 @@
<includes>
<include>**/*.java</include>
</includes>
<excludes>
<!-- java 21 style not yet supported -->
<exclude>sample-app/src/main/java/com/sinch/sample/webhooks/sms/SmsController.java</exclude>
<exclude>sample-app/src/main/java/com/sinch/sample/webhooks/verification/VerificationController.java</exclude>
<exclude>sample-app/src/main/java/com/sinch/sample/webhooks/voice/VoiceController.java</exclude>
</excludes>

<googleJavaFormat>
<version>1.18.1</version>
<version>1.22.0</version>
<style>GOOGLE</style>
<reflowLongStrings>true</reflowLongStrings>
</googleJavaFormat>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,4 @@ public void smsDeliveryEvent(
default -> throw new IllegalStateException("Unexpected value: " + event);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ public VoiceController(SinchClient sinchClient, VoiceService service) {
value = "/VoiceEvent",
consumes = MediaType.APPLICATION_JSON_VALUE,
produces = MediaType.APPLICATION_JSON_VALUE)
public String VoiceEvent(
@RequestHeader Map<String, String> headers, @RequestBody String body) {
public String VoiceEvent(@RequestHeader Map<String, String> headers, @RequestBody String body) {

LOGGER.finest("Received body:" + body);
LOGGER.finest("Received headers: " + headers);
Expand Down

0 comments on commit ea1d2a1

Please sign in to comment.