Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes (Numbers): Fixes for OptionalValue getter and DelegatedSerializer #114

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fixes (Numbers): Fixes for OptionalValue getter and DelegatedSerializer #114

merged 1 commit into from
Aug 12, 2024

Conversation

JPPortier
Copy link
Contributor

  • fix: OptionalValue getter for delegated fields wrongly returned OptionalValue.of(null) value instead of OptionalValue.empty() when delegated field was empty
  • fix: Guard against null for DelegatedSerializer

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@JPPortier JPPortier merged commit 515d6a1 into V1.3-next Aug 12, 2024
3 checks passed
@JPPortier JPPortier deleted the numbers-guard-null-DelegatedSerializer branch August 12, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asein-sinch asein-sinch asein-sinch approved these changes

@Dovchik Dovchik Awaiting requested review from Dovchik

@650elx 650elx Awaiting requested review from 650elx

@krogers0607 krogers0607 Awaiting requested review from krogers0607

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JPPortier @asein-sinch