Feat/DEVEXP-470: Voice V1 design #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se 'v1.callouts' APIs in place of '.callouts'
… in place of '.calls'
….conferences' APIs in place of '.conferences'
…oks' APIs in place of '.webhooks'
…v1.applications' APIs in place of '.applications'
… provide SDK's user facility in place of JSON encoded String
…'callouts.request' package
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
asein-sinch
reviewed
Oct 28, 2024
| * @param parameters Request parameters | ||
| * @since 1.4 | ||
| */ | ||
| public void unAssignNumber(UnAssignNumberRequest parameters); |
There was a problem hiding this comment.
Nit: unAssign or unassign, that is the question 💀
There was a problem hiding this comment.
Exact and was not confirmed to our mappingId -> name mapping table
Fixed
There was a problem hiding this comment.
Thanks, as discussed, there are other places where the name could be refactored to be consistent across all the code
asein-sinch
reviewed
Oct 28, 2024
client/src/main/com/sinch/sdk/domains/voice/api/v1/adapters/WebHooksService.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Oct 28, 2024
client/src/test/java/com/sinch/sdk/domains/voice/adapters/CallsServiceTest.java
Show resolved
Hide resolved
asein-sinch
reviewed
Oct 28, 2024
| @@ -67,8 +58,20 @@ void callTTS() throws ApiException { | |||
| @Test | |||
| void callCustom() throws ApiException { | |||
There was a problem hiding this comment.
Nit: to be renamed custom() to be aligned with the name of the tested method as it has been done for conference() and textToSpeech()
asein-sinch
reviewed
Oct 28, 2024
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mock; | ||
|
|
||
| class VoiceServiceTest { |
There was a problem hiding this comment.
Can you also add a test where there is a context, an application key and an application secret? Just to be sure it works when all the parameters are present :)
asein-sinch
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.