DEVEXP-215: SAVML helpers shared by custom callouts requests and webhooks #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m webhooks and callouts
…ptionAction helper to define SAVML menu navigation
JPPortier
requested review from
Dovchik,
650elx,
krogers0607 and
asein-sinch
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Manifest Files |
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/models/svaml/MenuOptionAction.java
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
...est/java/com/sinch/sdk/domains/voice/models/requests/CalloutRequestParametersCustomTest.java
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
...est/java/com/sinch/sdk/domains/voice/models/requests/CalloutRequestParametersCustomTest.java
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
...ntracts/src/test/java/com/sinch/sdk/domains/voice/models/dto/svaml/ActionRunMenuDtoTest.java
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/adapters/converters/SAVMLActionDtoConverter.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/models/svaml/InstructionSetCookie.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/models/svaml/InstructionPlayFiles.java
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/models/svaml/ActionConnectSip.java
Outdated
Show resolved
Hide resolved
asein-sinch
reviewed
Jan 30, 2024
client/src/main/com/sinch/sdk/domains/voice/adapters/converters/SAVMLActionDtoConverter.java
Show resolved
Hide resolved
…hineDetectionEnabled' to 'answeringMachineDetection'
asein-sinch
approved these changes
Jan 31, 2024
JPPortier
deleted the
DEVEXP-215-SAVML-helpers-shared-by-custom-callouts-requests-and-webhooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring for incoming webhooks, at commit level details: